fix(amazonq): bring back the removal of extra) ] } ' " after inline completion acceptance (#7783)

leigaol · web-flow · commit a41fde36fa5d · 2025-07-31T10:22:12.000-07:00
## Problem https://github.com/user-attachments/assets/56c70784-f92b-43dc-8f7e-b38b873a3784 When an inline completion is accepted, there can be extra ) ] } ' " that breaks the syntax. ## Solution https://github.com/user-attachments/assets/c84f1e6a-4f80-4605-a2e1-074047ac19bf Bring back old code that was used to remove the extra ) ] } ' " . https://github.com/user-attachments/assets/35a65fce-98c1-4819-8bc5-3cb5c9aad5ab Ref: https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/core/src/codewhisperer/util/closingBracketUtil.ts --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/packages/amazonq/src/app/inline/completion.ts b/packages/amazonq/src/app/inline/completion.ts
@@ -36,6 +36,7 @@ import {
     getDiagnosticsDifferences,
     getDiagnosticsOfCurrentFile,
     toIdeDiagnostics,
+    handleExtraBrackets,
 } from 'aws-core-vscode/codewhisperer'
 import { LineTracker } from './stateTracker/lineTracker'
 import { InlineTutorialAnnotation } from './tutorials/inlineTutorialAnnotation'
@@ -106,11 +107,12 @@ export class InlineCompletionManager implements Disposable {
             item: InlineCompletionItemWithReferences,
             editor: TextEditor,
             requestStartTime: number,
-            startLine: number,
+            position: vscode.Position,
             firstCompletionDisplayLatency?: number
         ) => {
             try {
                 vsCodeState.isCodeWhispererEditing = true
+                const startLine = position.line
                 // TODO: also log the seen state for other suggestions in session
                 // Calculate timing metrics before diagnostic delay
                 const totalSessionDisplayTime = performance.now() - requestStartTime
@@ -119,6 +121,11 @@ export class InlineCompletionManager implements Disposable {
                     this.sessionManager.getActiveSession()?.diagnosticsBeforeAccept,
                     getDiagnosticsOfCurrentFile()
                 )
+                // try remove the extra } ) ' " if there is a new reported problem
+                // the extra } will cause syntax error
+                if (diagnosticDiff.added.length > 0) {
+                    await handleExtraBrackets(editor, editor.selection.active, position)
+                }
                 const params: LogInlineCompletionSessionResultsParams = {
                     sessionId: sessionId,
                     completionSessionResult: {
@@ -304,7 +311,7 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
                                 item,
                                 editor,
                                 prevSession?.requestStartTime,
-                                position.line,
+                                position,
                                 prevSession?.firstCompletionDisplayLatency,
                             ],
                         }
@@ -441,7 +448,7 @@ ${itemLog}
                             item,
                             editor,
                             session.requestStartTime,
-                            cursorPosition.line,
+                            cursorPosition,
                             session.firstCompletionDisplayLatency,
                         ],
                     }
diff --git a/packages/core/src/codewhisperer/index.ts b/packages/core/src/codewhisperer/index.ts
@@ -68,6 +68,7 @@ export * from './util/importAdderUtil'
 export * from './util/zipUtil'
 export * from './util/diagnosticsUtil'
 export * from './util/commonUtil'
+export * from './util/closingBracketUtil'
 export * from './util/codewhispererSettings'
 export * from './service/diagnosticsProvider'
 export * as diagnosticsProvider from './service/diagnosticsProvider'
diff --git a/packages/core/src/codewhisperer/util/closingBracketUtil.ts b/packages/core/src/codewhisperer/util/closingBracketUtil.ts
@@ -0,0 +1,263 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ * Reference: https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/core/src/codewhisperer/util/closingBracketUtil.ts
+ */
+
+import * as vscode from 'vscode'
+import * as CodeWhispererConstants from '../models/constants'
+
+interface bracketMapType {
+    [k: string]: string
+}
+
+const quotes = ["'", '"', '`']
+const parenthesis = ['(', '[', '{', ')', ']', '}', '<', '>']
+
+const closeToOpen: bracketMapType = {
+    ')': '(',
+    ']': '[',
+    '}': '{',
+    '>': '<',
+}
+
+const openToClose: bracketMapType = {
+    '(': ')',
+    '[': ']',
+    '{': '}',
+    '<': '>',
+}
+
+/**
+ * LeftContext | Recommendation | RightContext
+ * This function aims to resolve symbols which are redundant and need to be removed
+ * The high level logic is as followed
+ *   1. Pair non-paired closing symbols(parenthesis, brackets, quotes) existing in the "recommendation" with non-paired symbols existing in the "leftContext"
+ *   2. Remove non-paired closing symbols existing in the "rightContext"
+ * @param endPosition: end position of the effective recommendation written by CodeWhisperer
+ * @param startPosition: start position of the effective recommendation by CodeWhisperer
+ *
+ * for example given file context ('|' is where we trigger the service):
+ * anArray.pu|
+ * recommendation returned: "sh(element);"
+ * typeahead: "sh("
+ * the effective recommendation written by CodeWhisperer: "element);"
+ */
+export async function handleExtraBrackets(
+    editor: vscode.TextEditor,
+    endPosition: vscode.Position,
+    startPosition: vscode.Position
+) {
+    const recommendation = editor.document.getText(new vscode.Range(startPosition, endPosition))
+    const endOffset = editor.document.offsetAt(endPosition)
+    const startOffset = editor.document.offsetAt(startPosition)
+    const leftContext = editor.document.getText(
+        new vscode.Range(
+            startPosition,
+            editor.document.positionAt(Math.max(startOffset - CodeWhispererConstants.charactersLimit, 0))
+        )
+    )
+
+    const rightContext = editor.document.getText(
+        new vscode.Range(
+            editor.document.positionAt(endOffset),
+            editor.document.positionAt(endOffset + CodeWhispererConstants.charactersLimit)
+        )
+    )
+    const bracketsToRemove = getBracketsToRemove(
+        editor,
+        recommendation,
+        leftContext,
+        rightContext,
+        endPosition,
+        startPosition
+    )
+
+    const quotesToRemove = getQuotesToRemove(
+        editor,
+        recommendation,
+        leftContext,
+        rightContext,
+        endPosition,
+        startPosition
+    )
+
+    const symbolsToRemove = [...bracketsToRemove, ...quotesToRemove]
+
+    if (symbolsToRemove.length) {
+        await removeBracketsFromRightContext(editor, symbolsToRemove, endPosition)
+    }
+}
+
+const removeBracketsFromRightContext = async (
+    editor: vscode.TextEditor,
+    idxToRemove: number[],
+    endPosition: vscode.Position
+) => {
+    const offset = editor.document.offsetAt(endPosition)
+
+    await editor.edit(
+        (editBuilder) => {
+            for (const idx of idxToRemove) {
+                const range = new vscode.Range(
+                    editor.document.positionAt(offset + idx),
+                    editor.document.positionAt(offset + idx + 1)
+                )
+                editBuilder.delete(range)
+            }
+        },
+        { undoStopAfter: false, undoStopBefore: false }
+    )
+}
+
+function getBracketsToRemove(
+    editor: vscode.TextEditor,
+    recommendation: string,
+    leftContext: string,
+    rightContext: string,
+    end: vscode.Position,
+    start: vscode.Position
+) {
+    const unpairedClosingsInReco = nonClosedClosingParen(recommendation)
+    const unpairedOpeningsInLeftContext = nonClosedOpneingParen(leftContext, unpairedClosingsInReco.length)
+    const unpairedClosingsInRightContext = nonClosedClosingParen(rightContext)
+
+    const toRemove: number[] = []
+
+    let i = 0
+    let j = 0
+    let k = 0
+    while (i < unpairedOpeningsInLeftContext.length && j < unpairedClosingsInReco.length) {
+        const opening = unpairedOpeningsInLeftContext[i]
+        const closing = unpairedClosingsInReco[j]
+
+        const isPaired = closeToOpen[closing.char] === opening.char
+        const rightContextCharToDelete = unpairedClosingsInRightContext[k]
+
+        if (isPaired) {
+            if (rightContextCharToDelete && rightContextCharToDelete.char === closing.char) {
+                const rightContextStart = editor.document.offsetAt(end) + 1
+                const symbolPosition = editor.document.positionAt(
+                    rightContextStart + rightContextCharToDelete.strOffset
+                )
+                const lineCnt = recommendation.split('\n').length - 1
+                const isSameline = symbolPosition.line - lineCnt === start.line
+
+                if (isSameline) {
+                    toRemove.push(rightContextCharToDelete.strOffset)
+                }
+
+                k++
+            }
+        }
+
+        i++
+        j++
+    }
+
+    return toRemove
+}
+
+function getQuotesToRemove(
+    editor: vscode.TextEditor,
+    recommendation: string,
+    leftContext: string,
+    rightContext: string,
+    endPosition: vscode.Position,
+    startPosition: vscode.Position
+) {
+    let leftQuote: string | undefined = undefined
+    let leftIndex: number | undefined = undefined
+    for (let i = leftContext.length - 1; i >= 0; i--) {
+        const char = leftContext[i]
+        if (quotes.includes(char)) {
+            leftQuote = char
+            leftIndex = leftContext.length - i
+            break
+        }
+    }
+
+    let rightQuote: string | undefined = undefined
+    let rightIndex: number | undefined = undefined
+    for (let i = 0; i < rightContext.length; i++) {
+        const char = rightContext[i]
+        if (quotes.includes(char)) {
+            rightQuote = char
+            rightIndex = i
+            break
+        }
+    }
+
+    let quoteCountInReco = 0
+    if (leftQuote && rightQuote && leftQuote === rightQuote) {
+        for (const char of recommendation) {
+            if (quotes.includes(char) && char === leftQuote) {
+                quoteCountInReco++
+            }
+        }
+    }
+
+    if (leftIndex !== undefined && rightIndex !== undefined && quoteCountInReco % 2 !== 0) {
+        const p = editor.document.positionAt(editor.document.offsetAt(endPosition) + rightIndex)
+
+        if (endPosition.line === startPosition.line && endPosition.line === p.line) {
+            return [rightIndex]
+        }
+    }
+
+    return []
+}
+
+function nonClosedOpneingParen(str: string, cnt?: number): { char: string; strOffset: number }[] {
+    const resultSet: { char: string; strOffset: number }[] = []
+    const stack: string[] = []
+
+    for (let i = str.length - 1; i >= 0; i--) {
+        const char = str[i]
+        if (char! in parenthesis) {
+            continue
+        }
+
+        if (char in closeToOpen) {
+            stack.push(char)
+            if (cnt && cnt === resultSet.length) {
+                return resultSet
+            }
+        } else if (char in openToClose) {
+            if (stack.length !== 0 && stack[stack.length - 1] === openToClose[char]) {
+                stack.pop()
+            } else {
+                resultSet.push({ char: char, strOffset: i })
+            }
+        }
+    }
+
+    return resultSet
+}
+
+function nonClosedClosingParen(str: string, cnt?: number): { char: string; strOffset: number }[] {
+    const resultSet: { char: string; strOffset: number }[] = []
+    const stack: string[] = []
+
+    for (let i = 0; i < str.length; i++) {
+        const char = str[i]
+        if (char! in parenthesis) {
+            continue
+        }
+
+        if (char in openToClose) {
+            stack.push(char)
+            if (cnt && cnt === resultSet.length) {
+                return resultSet
+            }
+        } else if (char in closeToOpen) {
+            if (stack.length !== 0 && stack[stack.length - 1] === closeToOpen[char]) {
+                stack.pop()
+            } else {
+                resultSet.push({ char: char, strOffset: i })
+            }
+        }
+    }
+
+    return resultSet
+}
