Skip to content

Commit a4c9e05

Browse files
authored
fix: create output channel before registering with c9 progress (#4415)
Output channel is used inside a c9 wrapper before it is created. ### Testing Packaged and things that use progress in c9 (e.g. upload lambda, upload s3) no longer fails. <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Update the changelog using `npm run newChange`. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots --> ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: aws-toolkit-automation <>
1 parent b085314 commit a4c9e05

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/toolkit/src/extensionShared.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ export async function activateShared(
7171
logAndShowWebviewError(error, webviewId, command)
7272
})
7373

74+
// Setup the logger
75+
const toolkitOutputChannel = vscode.window.createOutputChannel('AWS Toolkit', { log: true })
76+
await activateLogger(context, toolkitOutputChannel)
77+
globals.outputChannel = toolkitOutputChannel
78+
7479
if (isCloud9()) {
7580
vscode.window.withProgress = wrapWithProgressForCloud9(globals.outputChannel)
7681
context.subscriptions.push(
@@ -88,11 +93,6 @@ export async function activateShared(
8893
localize('AWS.channel.aws.remoteInvoke', '{0} Remote Invocations', getIdeProperties().company)
8994
)
9095

91-
// Setup the logger
92-
const toolkitOutputChannel = vscode.window.createOutputChannel('AWS Toolkit', { log: true })
93-
await activateLogger(context, toolkitOutputChannel)
94-
globals.outputChannel = toolkitOutputChannel
95-
9696
//setup globals
9797
globals.machineId = await getMachineId()
9898
globals.awsContext = new DefaultAwsContext()

0 commit comments

Comments
 (0)