cleanup

Author: David Hasani

packages/amazonq/test/e2e/amazonq/transformByQ.test.ts

@@ -163,8 +163,7 @@ describe('Amazon Q Code Transformation', function () {
 
             transformByQState.setSummaryFilePath(path.join(tmpDir, 'summary.md'))
 
-            // TO-DO: make this `isPartiallySucceeded`
-            transformByQState.setToSucceeded()
+            transformByQState.setToPartiallySucceeded()
 
             transformByQState
                 .getChatMessenger()

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts

@@ -542,8 +542,10 @@ export class Messenger {
             })
         }
 
-        // TO-DO: make this `isPartiallySucceeded`
-        if (transformByQState.isSucceeded() && message == CodeWhispererConstants.viewProposedChangesChatMessage) {
+        if (
+            transformByQState.isPartiallySucceeded() &&
+            message === CodeWhispererConstants.viewProposedChangesChatMessage
+        ) {
             // get permission to re-run job and view logs after partially successful job is downloaded
             this.sendFeedbackFormMessage(tabID)
         }

packages/core/src/codewhisperer/commands/startTransformByQ.ts

@@ -513,11 +513,7 @@ export async function startTransformationJob(uploadId: string, transformStartTim
         getLogger().error(`CodeTransformation: ${CodeWhispererConstants.failedToStartJobNotification}`, error)
         const errorMessage = (error as Error).message.toLowerCase()
         if (errorMessage.includes('too many active running jobs')) {
-            transformByQState.setJobFailureErrorNotification(
-                CodeWhispererConstants.tooManyJobsNotification
-                // TO-DO: change this text (and the ones below) to link to the docs around limits
-                // https://issues.amazon.com/issues/V1679684569
-            )
+            transformByQState.setJobFailureErrorNotification(CodeWhispererConstants.tooManyJobsNotification)
             transformByQState.setJobFailureErrorChatMessage(CodeWhispererConstants.tooManyJobsChatMessage)
         } else if (errorMessage.includes('lines of code limit breached')) {
             transformByQState.setJobFailureErrorNotification(

packages/core/src/codewhisperer/models/constants.ts

@@ -469,6 +469,9 @@ export const amazonQFeedbackKey = 'Amazon Q'
 
 export const amazonQFeedbackText = 'Submit feedback'
 
+// TO-DO: update link
+export const codeTransformTroubleshootStartJobFailed = ''
+
 export const codeTransformTroubleshootProjectSize =
     'https://docs.aws.amazon.com/amazonq/latest/qdeveloper-ug/troubleshooting-code-transformation.html#reduce-project-size'
 
@@ -611,17 +614,13 @@ export const failedToStartJobChatMessage =
 export const failedToStartJobNotification =
     'Amazon Q could not begin the transformation. Please try starting the transformation again.'
 
-export const tooManyJobsChatMessage =
-    "Sorry, I couldn't begin the transformation. You have too many active transformations running. Please try again after your other transformations have completed."
+export const tooManyJobsChatMessage = `Sorry, I couldn't begin the transformation. You have too many active transformations running. Please try again after your other transformations have completed. For more information, see the [Amazon Q documentation](${codeTransformTroubleshootStartJobFailed}).`
 
-export const tooManyJobsNotification =
-    'Amazon Q could not begin the transformation. You have too many active transformations running. Please try again after your other transformations have completed.'
+export const tooManyJobsNotification = `Amazon Q could not begin the transformation. You have too many active transformations running. Please try again after your other transformations have completed. For more information, see the [Amazon Q documentation](${codeTransformTroubleshootStartJobFailed}).`
 
-export const linesOfCodeLimitBreachedChatMessage =
-    "Sorry, I couldn't begin the transformation. You have exceeded the lines of code limit for your plan."
+export const linesOfCodeLimitBreachedChatMessage = `Sorry, I couldn't begin the transformation. You have exceeded the lines of code limit for your plan. For more information, see the [Amazon Q documentation](${codeTransformTroubleshootStartJobFailed}).`
 
-export const linesOfCodeLimitBreachedNotification =
-    'Amazon Q could not begin the transformation. You have exceeded the lines of code limit for your plan.'
+export const linesOfCodeLimitBreachedNotification = `Amazon Q could not begin the transformation. You have exceeded the lines of code limit for your plan. For more information, see the [Amazon Q documentation](${codeTransformTroubleshootStartJobFailed}).`
 
 export const failedToUploadProjectChatMessage =
     "Sorry, I couldn't upload your project. Please try starting the transformation again."