codewhisperer: loading status bar stuck on expired credentials (#3845)

Problem:

- The code first sets the CW status bar to loading.
- But it will return early if `AuthUtil.instance.isConnectionExpired()`
  fails.
- The issue is when we return early we do not revert the loading status
  and the status bar is stuck loading.

Solution:
- Set the status bar to loading after `AuthUtil.instance.isConnectionExpired()` check

Signed-off-by: nkomonen <[email protected]>

Author: nkomonen-amazon

.changes/next-release/Bug Fix-ac5446a2-e6dd-4e85-b27c-cf8f75ae5aa1.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "CodeWhisperer: fixed case where 'CodeWhisperer' status bar stuck loading"
+}

src/codewhisperer/service/inlineCompletionService.ts

@@ -85,7 +85,6 @@ export class InlineCompletionService {
         // Call report user decisions once to report recommendations leftover from last invocation.
         RecommendationHandler.instance.reportUserDecisions(-1)
 
-        this.setCodeWhispererStatusBarLoading()
         if (ClassifierTrigger.instance.shouldInvokeClassifier(editor.document.languageId)) {
             ClassifierTrigger.instance.recordClassifierResultForAutoTrigger(editor, autoTriggerType, event)
         }
@@ -98,6 +97,9 @@ export class InlineCompletionService {
             await AuthUtil.instance.notifyReauthenticate(isAutoTrigger)
             return
         }
+
+        this.setCodeWhispererStatusBarLoading()
+
         TelemetryHelper.instance.setInvocationStartTime(performance.now())
         RecommendationHandler.instance.checkAndResetCancellationTokens()
         RecommendationHandler.instance.documentUri = editor.document.uri