Skip to content

Commit a71fffe

Browse files
authored
feat(amazonq): use detector library url from server (#5568)
## Problem Dead links to detector library for some findings. ## Solution Use detector library url from the server response instead of building it from the client. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 1dd9064 commit a71fffe

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

packages/core/src/codewhisperer/service/diagnosticsProvider.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,13 @@ export function createSecurityDiagnostic(securityIssue: CodeScanIssue) {
7474
vscode.DiagnosticSeverity.Warning
7575
)
7676
securityDiagnostic.source = codewhispererDiagnosticSourceLabel
77-
securityDiagnostic.code = {
78-
value: securityIssue.detectorId,
79-
target: vscode.Uri.parse(securityIssue.recommendation.url),
80-
}
77+
const detectorUrl = securityIssue.recommendation.url
78+
securityDiagnostic.code = detectorUrl
79+
? {
80+
value: securityIssue.detectorId,
81+
target: vscode.Uri.parse(detectorUrl),
82+
}
83+
: securityIssue.detectorId
8184
securityDiagnostic.findingId = securityIssue.findingId
8285
return securityDiagnostic
8386
}

packages/core/src/codewhisperer/views/securityIssue/vue/root.vue

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939

4040
<div>
4141
<b>Detector library</b>
42-
<p>
42+
<p v-if="!detectorUrl || !detectorUrl.length">-</p>
43+
<p v-else>
4344
<a :href="detectorUrl">
4445
{{ detectorName }} <span class="icon icon-sm icon-vscode-link-external"></span>
4546
</a>
@@ -113,6 +114,7 @@ export default defineComponent({
113114
title: '',
114115
detectorId: '',
115116
detectorName: '',
117+
detectorUrl: '',
116118
severity: '',
117119
recommendationText: '',
118120
suggestedFix: '',
@@ -140,6 +142,7 @@ export default defineComponent({
140142
this.title = issue.title
141143
this.detectorId = issue.detectorId
142144
this.detectorName = issue.detectorName
145+
this.detectorUrl = issue.recommendation.url
143146
this.relatedVulnerabilities = issue.relatedVulnerabilities
144147
this.severity = issue.severity
145148
this.recommendationText = issue.recommendation.text
@@ -177,10 +180,6 @@ export default defineComponent({
177180
severityImage() {
178181
return severityImages[this.severity.toLowerCase()]
179182
},
180-
detectorUrl() {
181-
const slug = this.detectorId.split('@').shift()
182-
return `https://docs.aws.amazon.com/codeguru/detector-library/${slug}`
183-
},
184183
recommendationTextHtml() {
185184
return md.render(this.recommendationText)
186185
},

0 commit comments

Comments
 (0)