Skip to content

Commit a7ccd37

Browse files
committed
refactor: migrate withRetries to waitUntil
1 parent 74eabe9 commit a7ccd37

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

packages/core/src/shared/resourcefetcher/httpResourceFetcher.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class HttpResourceFetcher implements ResourceFetcher<Response> {
135135
}
136136

137137
export class RetryableResourceFetcher extends HttpResourceFetcher {
138-
private readonly retryNumber: number
138+
private readonly requestTimeoutMs: number
139139
private readonly retryIntervalMs: number
140140
private readonly resource: string
141141

@@ -155,13 +155,13 @@ export class RetryableResourceFetcher extends HttpResourceFetcher {
155155
showUrl,
156156
timeout,
157157
})
158-
this.retryNumber = retryNumber
158+
this.requestTimeoutMs = retryNumber * retryIntervalMs
159159
this.retryIntervalMs = retryIntervalMs
160160
this.resource = resource
161161
}
162162

163163
fetch(versionTag?: string) {
164-
return withRetries(
164+
return waitUntil(
165165
async () => {
166166
try {
167167
return await this.getNewETagContent(versionTag)
@@ -171,8 +171,9 @@ export class RetryableResourceFetcher extends HttpResourceFetcher {
171171
}
172172
},
173173
{
174-
maxRetries: this.retryNumber,
175-
delay: this.retryIntervalMs,
174+
timeout: this.requestTimeoutMs,
175+
interval: this.retryIntervalMs,
176+
retryOnFail: true,
176177
}
177178
)
178179
}

0 commit comments

Comments
 (0)