Skip to content

Commit a81d599

Browse files
authored
fix(sam): update version notification wording (#3290)
1 parent 282ad7e commit a81d599

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/shared/localizedText.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export const recentlyUsed = localize('AWS.generic.recentlyUsed', 'recently used'
2323
export const viewSettings = localize('AWS.generic.viewSettings', 'View Settings')
2424
export const dontShow = localize('aws.generic.doNotShowAgain', "Don't Show Again")
2525
export const loadMore = localize('AWS.generic.loadMore', 'Load More')
26+
export const learnMore = localize('AWS.generic.learnMore', 'Learn More')
2627

2728
export const checklogs = () =>
2829
localize(

src/shared/sam/sync.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,11 +417,16 @@ export async function runSamSync(args: SyncParams) {
417417

418418
if ((parsedVersion?.compare('1.78.0') ?? 1) < 0) {
419419
showOnce('sam.sync.updateMessage', async () => {
420+
const message = `Your current version of SAM CLI (${parsedVersion?.version}) does not include performance improvements for "sam sync". Update to 1.78.0 or higher for faster deployments.`
421+
const learnMoreUrl = vscode.Uri.parse(
422+
'https://aws.amazon.com/about-aws/whats-new/2023/03/aws-toolkits-jetbrains-vs-code-sam-accelerate/'
423+
)
420424
const openDocsItem = 'Open Upgrade Documentation'
421-
const message = `Your current version of SAM CLI (${parsedVersion?.version}) does not include performance improvements for "sam sync". Update to 1.78.0 or higher for faster executions.`
422-
const resp = await vscode.window.showInformationMessage(message, openDocsItem)
425+
const resp = await vscode.window.showInformationMessage(message, localizedText.learnMore, openDocsItem)
423426
if (resp === openDocsItem) {
424427
await openUrl(samUpgradeUrl)
428+
} else if (resp === localizedText.learnMore) {
429+
await openUrl(learnMoreUrl)
425430
}
426431
})
427432
}

0 commit comments

Comments
 (0)