Skip to content

Commit a84e0ef

Browse files
authored
Merge #3781 fix: ConsoleLogger bugs
2 parents 3cd8387 + 142066c commit a84e0ef

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/shared/logger/logger.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,31 +100,32 @@ export class NullLogger implements Logger {
100100
}
101101

102102
/**
103-
* Fallback to console.log() if getLogger() is requested before logging is fully initialized.
103+
* Fallback used if {@link getLogger()} is requested before logging is fully initialized.
104104
*/
105105
export class ConsoleLogger implements Logger {
106106
public setLogLevel(logLevel: LogLevel) {}
107107
public logLevelEnabled(logLevel: LogLevel): boolean {
108108
return false
109109
}
110110
public debug(message: string | Error, ...meta: any[]): number {
111-
console.trace(message, meta)
111+
console.debug(message, ...meta)
112112
return 0
113113
}
114114
public verbose(message: string | Error, ...meta: any[]): number {
115-
console.debug(message, meta)
115+
console.debug(message, ...meta)
116116
return 0
117117
}
118118
public info(message: string | Error, ...meta: any[]): number {
119-
console.info(message, meta)
119+
console.info(message, ...meta)
120120
return 0
121121
}
122122
public warn(message: string | Error, ...meta: any[]): number {
123-
console.warn(message, meta)
123+
console.warn(message, ...meta)
124124
return 0
125125
}
126+
/** Note: In nodejs this prints to `stderr` (see {@link Console.error}). */
126127
public error(message: string | Error, ...meta: any[]): number {
127-
console.error(message, meta)
128+
console.error(message, ...meta)
128129
return 0
129130
}
130131
public getLogById(logID: number, file: Uri): string | undefined {

0 commit comments

Comments
 (0)