fix flaky test

Signed-off-by: nkomonen-amazon <[email protected]>

Author: nkomonen-amazon

packages/core/src/shared/crashMonitoring.ts

@@ -466,7 +466,9 @@ export class FileSystemState {
     public async indicateGracefulShutdown(): Promise<void> {
         // By removing the heartbeat entry, the crash checkers will not be able to find this entry anymore, making it
         // impossible to report on since the file system is the source of truth
-        await withFailCtx('indicateGracefulShutdown', () => nodeFs.rm(this.makeStateFilePath(this.extId)))
+        await withFailCtx('indicateGracefulShutdown', () =>
+            nodeFs.rm(this.makeStateFilePath(this.extId), { force: true })
+        )
     }
 
     // ------------------ Checker Methods ------------------

packages/core/src/test/shared/crashMonitoring.test.ts

@@ -30,7 +30,7 @@ export const crashMonitoringTest = async () => {
 
     // Add some buffer since after 1 interval the work is actually done, including file i/o which may be slow.
     // **IF FLAKY**, see if increasing the buffer helps.
-    const oneInterval = checkInterval + 500
+    const oneInterval = checkInterval + 1000
 
     /**
      * Makes N "extension instances" that can be used for testing.
@@ -122,6 +122,7 @@ export const crashMonitoringTest = async () => {
             await exts[i].ext.start()
         }
 
+        // Crash all exts except the 0th one
         for (let i = 1; i < extCount; i++) {
             await exts[i].ext.crash()
             latestCrashedExts.push(exts[i])