Skip to content

Commit a90ae99

Browse files
liramon1yuxianrz
authored andcommitted
Remove STS cache watcher
1 parent 7919e19 commit a90ae99

File tree

4 files changed

+1
-30
lines changed

4 files changed

+1
-30
lines changed

packages/core/src/auth/auth2.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ import { LanguageClient } from 'vscode-languageclient'
5757
import { getLogger } from '../shared/logger/logger'
5858
import { ToolkitError } from '../shared/errors'
5959
import { useDeviceFlow } from './sso/ssoAccessTokenProvider'
60-
import { getCacheDir, getCacheFileWatcher, getFlareCacheFileName, getStsCacheDir } from './sso/cache'
60+
import { getCacheDir, getCacheFileWatcher, getFlareCacheFileName } from './sso/cache'
6161
import { VSCODE_EXTENSION_ID } from '../shared/extensions'
6262
import { IamCredentials } from '@aws/language-server-runtimes-types'
6363
import globals from '../shared/extensionGlobals'
@@ -89,8 +89,6 @@ export type LoginType = (typeof LoginTypes)[keyof typeof LoginTypes]
8989

9090
export type cacheChangedEvent = 'delete' | 'create'
9191

92-
export type stsCacheChangedEvent = 'delete' | 'create'
93-
9492
export type Login = SsoLogin | IamLogin
9593

9694
export type TokenSource = IamIdentityCenterSsoTokenSource | AwsBuilderIdSsoTokenSource
@@ -116,10 +114,6 @@ const IamProfileOptionsDefaults = {
116114
*/
117115
export class LanguageClientAuth {
118116
readonly #ssoCacheWatcher = getCacheFileWatcher(getCacheDir(), getFlareCacheFileName(VSCODE_EXTENSION_ID.amazonq))
119-
readonly #stsCacheWatcher = getCacheFileWatcher(
120-
getStsCacheDir(),
121-
getFlareCacheFileName(VSCODE_EXTENSION_ID.amazonq)
122-
)
123117

124118
constructor(
125119
private readonly client: LanguageClient,
@@ -131,10 +125,6 @@ export class LanguageClientAuth {
131125
return this.#ssoCacheWatcher
132126
}
133127

134-
public get stsCacheWatcher() {
135-
return this.#stsCacheWatcher
136-
}
137-
138128
getSsoToken(
139129
tokenSource: TokenSource,
140130
login: boolean = false,
@@ -291,11 +281,6 @@ export class LanguageClientAuth {
291281
this.cacheWatcher.onDidCreate(() => cacheChangedHandler('create'))
292282
this.cacheWatcher.onDidDelete(() => cacheChangedHandler('delete'))
293283
}
294-
295-
registerStsCacheWatcher(stsCacheChangedHandler: (event: stsCacheChangedEvent) => any) {
296-
this.stsCacheWatcher.onDidCreate(() => stsCacheChangedHandler('create'))
297-
this.stsCacheWatcher.onDidDelete(() => stsCacheChangedHandler('delete'))
298-
}
299284
}
300285

301286
/**

packages/core/src/auth/sso/cache.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ export interface SsoCache {
3636
}
3737

3838
const defaultCacheDir = () => path.join(fs.getUserHomeDir(), '.aws/sso/cache')
39-
const defaultStsCacheDir = () => path.join(fs.getUserHomeDir(), '.aws/flare/cache')
4039
export const getCacheDir = () => DevSettings.instance.get('ssoCacheDirectory', defaultCacheDir())
41-
export const getStsCacheDir = () => DevSettings.instance.get('stsCacheDirectory', defaultStsCacheDir())
4240

4341
export function getCache(directory = getCacheDir()): SsoCache {
4442
return {

packages/core/src/codewhisperer/util/authUtil.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import { telemetry } from '../../shared/telemetry/telemetry'
3333
import {
3434
AuthStateEvent,
3535
cacheChangedEvent,
36-
stsCacheChangedEvent,
3736
LanguageClientAuth,
3837
Login,
3938
SsoLogin,
@@ -117,7 +116,6 @@ export class AuthUtil implements IAuthProvider {
117116
await this.setVscodeContextProps()
118117
})
119118
lspAuth.registerCacheWatcher(async (event: cacheChangedEvent) => await this.cacheChangedHandler(event))
120-
lspAuth.registerStsCacheWatcher(async (event: stsCacheChangedEvent) => await this.stsCacheChangedHandler(event))
121119
}
122120

123121
// Do NOT use this in production code, only used for testing
@@ -363,15 +361,6 @@ export class AuthUtil implements IAuthProvider {
363361
}
364362
}
365363

366-
private async stsCacheChangedHandler(event: stsCacheChangedEvent) {
367-
this.logger.debug(`Sts Cache change event received: ${event}`)
368-
if (event === 'delete') {
369-
await this.logout()
370-
} else if (event === 'create') {
371-
await this.restore()
372-
}
373-
}
374-
375364
private async stateChangeHandler(e: AuthStateEvent) {
376365
if (e.state === 'refreshed') {
377366
if (this.isSsoSession()) {

packages/core/src/test/testAuthUtil.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ export async function createTestAuthUtil() {
5858
updateIamProfile: sinon.stub().resolves(),
5959
invalidateSsoToken: sinon.stub().resolves(),
6060
registerCacheWatcher: sinon.stub().resolves(),
61-
registerStsCacheWatcher: sinon.stub().resolves(),
6261
encryptionKey,
6362
}
6463

0 commit comments

Comments
 (0)