Merge staging into feature/lambda-get-started

Author: aws-toolkit-automation

packages/core/src/shared/errors.ts

@@ -565,6 +565,10 @@ export class PermissionsError extends ToolkitError {
 }
 
 export function isNetworkError(err?: unknown): err is Error & { code: string } {
+    if (isVSCodeProxyError(err)) {
+        return true
+    }
+
     if (!hasCode(err)) {
         return false
     }
@@ -584,3 +588,17 @@ export function isNetworkError(err?: unknown): err is Error & { code: string } {
         'EADDRNOTAVAIL', // port not available/allowed?
     ].includes(err.code)
 }
+
+/**
+ * This error occurs on a network call if the user has set up a proxy in the
+ * VS Code settings but the proxy is not reachable.
+ *
+ * Setting ID: http.proxy
+ */
+function isVSCodeProxyError(err?: unknown): boolean {
+    if (!(err instanceof Error)) {
+        return false
+    }
+
+    return err.name === 'Error' && err.message.startsWith('Failed to establish a socket connection to proxies')
+}

packages/core/src/test/shared/errors.test.ts

@@ -11,6 +11,7 @@ import {
     getErrorMsg,
     getTelemetryReason,
     getTelemetryResult,
+    isNetworkError,
     resolveErrorMessageToDisplay,
     ToolkitError,
 } from '../../shared/errors'
@@ -416,4 +417,17 @@ describe('util', function () {
         ;(err as any).error_description = 'aws error desc 1'
         assert.deepStrictEqual(getErrorMsg(err), 'aws error desc 1')
     })
+
+    it('isNetworkError()', function () {
+        assert.deepStrictEqual(
+            isNetworkError(new Error('Failed to establish a socket connection to proxies BLAH BLAH BLAH')),
+            true,
+            'Did not return "true" on a VS Code Proxy error'
+        )
+        assert.deepStrictEqual(
+            isNetworkError(new Error('I am NOT a network error')),
+            false,
+            'Incorrectly indicated as network error'
+        )
+    })
 })