fixup! fixup! fix(childprocess): noisy "memory threshold" logs

Author: justinmk3

packages/core/src/shared/utilities/collectionUtils.ts

@@ -588,4 +588,8 @@ export class CircularBuffer {
     contains(value: number): boolean {
         return this.buffer.has(value)
     }
+
+    clear(): void {
+        this.buffer.clear()
+    }
 }

packages/core/src/shared/utilities/processUtils.ts

@@ -74,7 +74,7 @@ export class ChildProcessTracker {
         cpu: 50,
     }
     static readonly logger = logger.getLogger('childProcess')
-    static readonly #loggedPids = new CircularBuffer(1000)
+    static readonly loggedPids = new CircularBuffer(1000)
     #processByPid: Map<number, ChildProcess> = new Map<number, ChildProcess>()
     #pids: PollingSet<number>
 
@@ -118,8 +118,8 @@ export class ChildProcessTracker {
     }
 
     public static logOnce(pid: number, msg: string) {
-        if (!ChildProcessTracker.#loggedPids.contains(pid)) {
-            ChildProcessTracker.#loggedPids.add(pid)
+        if (!ChildProcessTracker.loggedPids.contains(pid)) {
+            ChildProcessTracker.loggedPids.add(pid)
             ChildProcessTracker.logger.warn(msg)
         }
     }

packages/core/src/test/shared/utilities/processUtils.test.ts

@@ -393,6 +393,10 @@ describe('ChildProcessTracker', function () {
         usageMock = sinon.stub(ChildProcessTracker.prototype, 'getUsage')
     })
 
+    beforeEach(function () {
+        ChildProcessTracker.loggedPids.clear()
+    })
+
     afterEach(function () {
         tracker.clear()
         usageMock.reset()
@@ -463,6 +467,7 @@ describe('ChildProcessTracker', function () {
         await clock.tickAsync(ChildProcessTracker.pollingInterval)
         assertLogsContain('exceeded cpu threshold', false, 'warn')
 
+        ChildProcessTracker.loggedPids.clear()
         usageMock.returns(highMemory)
         await clock.tickAsync(ChildProcessTracker.pollingInterval)
         assertLogsContain('exceeded memory threshold', false, 'warn')