Changes to solve duplicate error

Author: Vandita Patidar

packages/core/src/test/awsService/appBuilder/serverlessLand/main.test.ts

@@ -81,6 +81,20 @@ describe('createNewServerlessLandProject', () => {
     })
 })
 
+function assertDownloadPatternCall(getPatternStub: sinon.SinonStub, mockConfig: any) {
+    const mockAssetName = 'test-project-sam-python.zip'
+    const serverlessLandOwner = 'aws-samples'
+    const serverlessLandRepo = 'serverless-patterns'
+    const mockLocation = vscode.Uri.joinPath(mockConfig.location, mockConfig.name)
+
+    assert(getPatternStub.calledOnce)
+    assert(getPatternStub.firstCall.args[0] === serverlessLandOwner)
+    assert(getPatternStub.firstCall.args[1] === serverlessLandRepo)
+    assert(getPatternStub.firstCall.args[2] === mockAssetName)
+    assert(getPatternStub.firstCall.args[3].toString() === mockLocation.toString())
+    assert(getPatternStub.firstCall.args[4] === true)
+}
+
 describe('downloadPatternCode', () => {
     let sandbox: sinon.SinonSandbox
     let getPatternStub: sinon.SinonStub
@@ -104,64 +118,17 @@ describe('downloadPatternCode', () => {
     })
 
     it('successfully downloads pattern code', async () => {
-        const mockAssetName = 'test-project-sam-python.zip'
-        const serverlessLandOwner = 'aws-samples'
-        const serverlessLandRepo = 'serverless-patterns'
-        const mockLocation = vscode.Uri.joinPath(mockConfig.location, mockConfig.name)
-
         await downloadPatternCode(mockConfig, mockConfig.assetName)
-        assert(getPatternStub.calledOnce)
-        assert(getPatternStub.firstCall.args[0] === serverlessLandOwner)
-        assert(getPatternStub.firstCall.args[1] === serverlessLandRepo)
-        assert(getPatternStub.firstCall.args[2] === mockAssetName)
-        assert(getPatternStub.firstCall.args[3].toString() === mockLocation.toString())
-        assert(getPatternStub.firstCall.args[4] === true)
+        assertDownloadPatternCall(getPatternStub, mockConfig)
     })
-    it('handles download failure', async () => {
-        const error = new Error('Download failed')
-        getPatternStub.rejects(error)
-        try {
-            await downloadPatternCode(mockConfig, mockConfig.assetName)
-            assert.fail('Expected an error to be thrown')
-        } catch (err: any) {
-            assert.strictEqual(err.message, 'Failed to download pattern: Error: Download failed')
-        }
-    })
-    it('downloads pattern when directory exists and user confirms overwrite', async function () {
-        const mockAssetName = 'test-project-sam-python.zip'
-        const serverlessLandOwner = 'aws-samples'
-        const serverlessLandRepo = 'serverless-patterns'
-        const mockLocation = vscode.Uri.joinPath(mockConfig.location, mockConfig.name)
 
+    it('downloads pattern when directory exists and user confirms overwrite', async function () {
         getTestWindow().onDidShowMessage((message) => {
             message.selectItem('Yes')
         })
 
         await downloadPatternCode(mockConfig, mockConfig.assetName)
-        assert(getPatternStub.calledOnce)
-        assert(getPatternStub.firstCall.args[0] === serverlessLandOwner)
-        assert(getPatternStub.firstCall.args[1] === serverlessLandRepo)
-        assert(getPatternStub.firstCall.args[2] === mockAssetName)
-        assert(getPatternStub.firstCall.args[3].toString() === mockLocation.toString())
-        assert(getPatternStub.firstCall.args[4] === true)
-    })
-    it('aborts download when directory exists and user declines overwrite', async function () {
-        const existsStub = sinon.stub(fs, 'exists').resolves(true)
-
-        const messagePromise = new Promise<void>((resolve) => {
-            getTestWindow().onDidShowMessage((message) => {
-                resolve()
-                message.selectItem('No')
-            })
-        })
-        try {
-            await Promise.all([messagePromise, downloadPatternCode(mockConfig, mockConfig.assetName)])
-            assert.fail('Folder already exists: test-project')
-        } catch (e) {
-            assert.strictEqual((e as Error).message, `Folder already exists: ${mockConfig.name}`)
-        }
-        assert(getPatternStub.notCalled)
-        existsStub.restore()
+        assertDownloadPatternCall(getPatternStub, mockConfig)
     })
 })