Merge master into feature/falcon

Author: aws-toolkit-automation

packages/core/src/login/webview/commonAuthViewProvider.ts

@@ -124,8 +124,6 @@ export class CommonAuthViewProvider implements WebviewViewProvider {
             }
 
             this.onDidChangeVisibility?.fire(webviewView.visible)
-            // force webview to reload
-            await vscode.commands.executeCommand('workbench.action.webview.reloadWebviewAction')
         })
 
         const dist = Uri.joinPath(this.extensionContext.extensionUri, 'dist')

packages/core/src/login/webview/vue/backend.ts

@@ -61,27 +61,18 @@ export abstract class CommonAuthWebview extends VueWebview {
         return globals.regionProvider.getRegions().reverse()
     }
 
-    private didCall: { login: boolean; reauth: boolean } = { login: false, reauth: false }
     /**
      * Called when the UI load process is completed, regardless of success or failure
      *
      * @param errorMessage IF an error is caught on the frontend, this is the message. It will result in a failure metric.
      *                     Otherwise we assume success.
      */
     public setUiReady(state: 'login' | 'reauth', errorMessage?: string) {
-        // Only emit once to prevent telemetry spam, since showing/hiding chat triggers this each time.
-        // TODO: Research how to not trigger this on every show/hide
-        if (this.didCall[state]) {
-            return
-        }
-
         if (errorMessage) {
             this.setLoadFailure(state, errorMessage)
         } else {
             this.setDidLoad(state)
         }
-
-        this.didCall[state] = true
     }
 
     /**