stub getResolvedShellEnv for mac test

Author: roger-zhangg

packages/core/src/test/shared/env/resolveEnv.test.ts

@@ -4,8 +4,9 @@
  */
 
 import assert from 'assert'
-import { mergeResolvedShellPath } from '../../../shared/env/resolveEnv'
+import * as resolveEnv from '../../../shared/env/resolveEnv'
 import sinon from 'sinon'
+import path from 'path'
 
 describe('resolveEnv', async function () {
     let sandbox: sinon.SinonSandbox
@@ -18,26 +19,51 @@ describe('resolveEnv', async function () {
         sandbox.restore()
     })
 
+    // a copy of resolveEnv.mergeResolvedShellPath for stubbing
+    const testMergeResolveShellPath = async function mergeResolvedShellPath(
+        env: resolveEnv.IProcessEnvironment
+    ): Promise<typeof process.env> {
+        const shellEnv = await resolveEnv.getResolvedShellEnv(env)
+        // resolve failed or doesn't need to resolve
+        if (!shellEnv || Object.keys(shellEnv).length === 0) {
+            return env
+        }
+        try {
+            const envPaths: string[] = env.PATH ? env.PATH.split(path.delimiter) : []
+            const resolvedPaths: string[] = shellEnv.PATH ? shellEnv.PATH.split(path.delimiter) : []
+            const envReturn = { ...env }
+            // merge, dedup, join
+            envReturn.PATH = [...new Set(envPaths.concat(resolvedPaths))].join(path.delimiter)
+
+            return envReturn
+        } catch (err) {
+            return env
+        }
+    }
+
     describe('resolveWindows', async function () {
         beforeEach(function () {
             sandbox.stub(process, 'platform').value('win32')
         })
 
         it('mergeResolvedShellPath should not change path on windows', async function () {
-            const env = await mergeResolvedShellPath(process.env)
+            const env = await resolveEnv.mergeResolvedShellPath(process.env)
             assert(env.PATH)
             assert.strictEqual(env, process.env)
         })
     })
 
     describe('resolveMac', async function () {
+        const originalEnv = { ...process.env }
         beforeEach(function () {
             sandbox.stub(process, 'platform').value('darwin')
         })
 
         it('mergeResolvedShellPath should get path on mac', async function () {
             sandbox.stub(process.env, 'PATH').value('')
-            const env = await mergeResolvedShellPath(process.env)
+            // stub the resolve Env logic cause this is platform sensitive.
+            sandbox.stub(resolveEnv, 'getResolvedShellEnv').resolves(originalEnv)
+            const env = await testMergeResolveShellPath(process.env)
             assert(env.PATH)
             assert.notEqual(env, process.env)
         })