adjust test cases

Author: Hweinstock

packages/core/src/awsService/ec2/utils.ts

@@ -53,5 +53,5 @@ export function getEc2SsmEnv(
  * @returns bash command to remove lines from file.
  */
 export function getRemoveLinesCommand(hintComment: string, filepath: string): string {
-    return `sed /${hintComment}/d ${filepath}`
+    return `sed -i '' /${hintComment}/d ${filepath}`
 }

packages/core/src/test/awsService/ec2/utils.test.ts

@@ -7,7 +7,7 @@ import assert from 'assert'
 import * as sinon from 'sinon'
 import { SafeEc2Instance } from '../../../shared/clients/ec2Client'
 import { getIconCode, getRemoveLinesCommand } from '../../../awsService/ec2/utils'
-import { DefaultAwsContext, globals } from '../../../shared'
+import { DefaultAwsContext } from '../../../shared'
 import { fs } from '../../../shared/fs/fs'
 import { createTestWorkspaceFolder } from '../../testUtil'
 import path from 'path'
@@ -58,23 +58,35 @@ describe('utils', async function () {
     })
 
     describe('getRemoveLinesCommand', async function () {
+        let tempPath: { uri: { fsPath: string } }
+
+        before(async function () {
+            tempPath = await createTestWorkspaceFolder()
+        })
+
+        after(async function () {
+            await fs.delete(tempPath.uri.fsPath, { recursive: true, force: true })
+        })
+
         it('removes lines prefixed by pattern', async function () {
-            const pattern = 'pattern'
             const lines = ['line1', 'line2 pattern', 'line3', 'line4 pattern', 'line5', 'line6 pattern', 'line7']
             const expected = ['line1', 'line3', 'line5', 'line7']
-            const tempPath = await createTestWorkspaceFolder()
+
+            const lineToStr = (ls: string[]) => ls.join('\n') + '\n'
+
             const textFile = path.join(tempPath.uri.fsPath, 'test.txt')
-            await fs.writeFile(textFile, lines.join('\n'))
+            const originalContent = lineToStr(lines)
+            await fs.writeFile(textFile, originalContent)
 
-            const [command, ...args] = getRemoveLinesCommand(pattern, textFile).split(' ')
+            const [command, ...args] = getRemoveLinesCommand('pattern', textFile).split(' ')
             const process = new ChildProcess(command, args, { collect: true })
             const result = await process.run()
 
             assert.strictEqual(result.exitCode, 0, `ChildProcess failed with error=${result.error}`)
-            const newContent = await fs.readFileText(textFile)
 
-            assert.strictEqual(newContent, expected.join('\n') + '\n')
-            await fs.delete(tempPath.uri.fsPath, { recursive: true, force: true })
+            const newContent = await fs.readFileText(textFile)
+            assert.notStrictEqual(newContent, originalContent)
+            assert.strictEqual(newContent, lineToStr(expected))
         })
     })
 })