refactor: migrate listConnections

Author: Hweinstock

packages/core/src/awsService/apprunner/wizards/codeRepositoryWizard.ts

@@ -158,10 +158,12 @@ export function createConnectionPrompter(client: AppRunnerClient) {
     const getItems = async () => {
         const resp = await client.listConnections()
 
-        return resp.ConnectionSummaryList.filter((conn) => conn.Status === 'AVAILABLE').map((conn) => ({
-            label: conn.ConnectionName!,
-            data: conn,
-        }))
+        return resp
+            .filter((conn) => conn.Status === 'AVAILABLE')
+            .map((conn) => ({
+                label: conn.ConnectionName!,
+                data: conn,
+            }))
     }
 
     const refreshButton = createRefreshButton()

packages/core/src/shared/clients/apprunner.ts

@@ -7,12 +7,19 @@ import { AppRunner } from 'aws-sdk'
 import globals from '../extensionGlobals'
 import {
     AppRunnerClient as AppRunnerClientSDK,
+    ConnectionSummary,
+    CreateConnectionCommand,
+    CreateConnectionRequest,
+    CreateConnectionResponse,
     DeleteServiceCommand,
     DeleteServiceRequest,
     DeleteServiceResponse,
     DescribeServiceCommand,
     DescribeServiceRequest,
     DescribeServiceResponse,
+    ListConnectionsCommand,
+    ListConnectionsRequest,
+    ListConnectionsResponse,
     ListServicesCommand,
     ListServicesRequest,
     ListServicesResponse,
@@ -79,16 +86,13 @@ export class AppRunnerClient extends ClientWrapper<AppRunnerClientSDK> {
         return await this.makeRequest(UpdateServiceCommand, request)
     }
 
-    public async createConnection(
-        request: AppRunner.CreateConnectionRequest
-    ): Promise<AppRunner.CreateConnectionResponse> {
-        return (await this.createSdkClient()).createConnection(request).promise()
+    public async createConnection(request: CreateConnectionRequest): Promise<CreateConnectionResponse> {
+        return await this.makeRequest(CreateConnectionCommand, request)
     }
 
-    public async listConnections(
-        request: AppRunner.ListConnectionsRequest = {}
-    ): Promise<AppRunner.ListConnectionsResponse> {
-        return (await this.createSdkClient()).listConnections(request).promise()
+    public async listConnections(request: ListConnectionsRequest = {}): Promise<ConnectionSummary[]> {
+        const result: ListConnectionsResponse = await this.makeRequest(ListConnectionsCommand, request)
+        return result.ConnectionSummaryList ?? []
     }
 
     public async describeService(

packages/core/src/test/awsService/apprunner/wizards/codeRepositoryWizard.test.ts

@@ -11,12 +11,12 @@ import {
     createConnectionPrompter,
 } from '../../../../awsService/apprunner/wizards/codeRepositoryWizard'
 import { AppRunnerClient } from '../../../../shared/clients/apprunner'
-import { ConnectionSummary } from 'aws-sdk/clients/apprunner'
 import { WIZARD_EXIT } from '../../../../shared/wizards/wizard'
 import { apprunnerConnectionHelpUrl } from '../../../../shared/constants'
 import { createQuickPickPrompterTester, QuickPickPrompterTester } from '../../../shared/ui/testUtils'
 import { stub } from '../../../utilities/stubber'
 import { getOpenExternalStub } from '../../../globalSetup.test'
+import { ConnectionSummary } from '@aws-sdk/client-apprunner'
 
 describe('AppRunnerCodeRepositoryWizard', function () {
     let tester: WizardTester<AppRunner.SourceConfiguration>
@@ -72,7 +72,7 @@ describe('createConnectionPrompter', function () {
 
     function makeTester(connections = defaultConnections): QuickPickPrompterTester<ConnectionSummary> {
         const client = stub(AppRunnerClient, { regionCode: '' })
-        client.listConnections.resolves({ ConnectionSummaryList: connections })
+        client.listConnections.resolves(connections)
 
         return createQuickPickPrompterTester(createConnectionPrompter(client))
     }