Merge master into feature/cwltail

Author: aws-toolkit-automation

packages/core/src/awsService/ec2/utils.ts

@@ -18,6 +18,10 @@ export function getIconCode(instance: SafeEc2Instance) {
         return 'circle-slash'
     }
 
+    if (instance.LastSeenStatus === 'terminated') {
+        return 'stop'
+    }
+
     return 'loading~spin'
 }
 

packages/core/src/test/awsService/ec2/utils.test.ts

@@ -28,9 +28,14 @@ describe('utils', async function () {
                 InstanceId: 'XX',
                 LastSeenStatus: 'stopped',
             }
+            const terminatedInstance: SafeEc2Instance = {
+                InstanceId: 'XXX',
+                LastSeenStatus: 'terminated',
+            }
 
             assert.strictEqual(getIconCode(runningInstance), 'pass')
             assert.strictEqual(getIconCode(stoppedInstance), 'circle-slash')
+            assert.strictEqual(getIconCode(terminatedInstance), 'stop')
         })
 
         it('defaults to loading~spin', function () {

packages/toolkit/.changes/next-release/Bug Fix-f010c52a-8c90-46b2-9def-fb8d9d48cbfb.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "EC2: terminated instances no longer show pending icon"
+}