Skip to content

Commit b41d29a

Browse files
committed
revert vscode version changes
1 parent b0b7bd1 commit b41d29a

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"license": "Apache-2.0",
1010
"engines": {
1111
"npm": "^10.1.0",
12-
"vscode": "^1.83.0"
12+
"vscode": "^1.68.0"
1313
},
1414
"activationEvents": [
1515
"onStartupFinished",

packages/core/src/test/techdebt.test.ts

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,31 +3,34 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
// import assert from 'assert'
7-
// import * as semver from 'semver'
8-
// import * as env from '../shared/vscode/env'
6+
import assert from 'assert'
7+
import * as semver from 'semver'
8+
import * as env from '../shared/vscode/env'
99

1010
// Checks project config and dependencies, to remind us to remove old things
1111
// when possible.
1212
describe('tech debt', function () {
1313
it('vscode minimum version', async function () {
14-
// const minVscode = env.getMinVscodeVersion()
15-
// assert.ok(
16-
// semver.lt(minVscode, '1.75.0'),
17-
// 'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead (after Cloud9 VFS fixes bug)'
18-
// )
19-
// assert.ok(
20-
// semver.lt(minVscode, '1.75.0'),
21-
// 'remove AsyncLocalStorage polyfill used in `spans.ts` if Cloud9 is on node 14+'
22-
// )
14+
const minVscode = env.getMinVscodeVersion()
15+
16+
assert.ok(
17+
semver.lt(minVscode, '1.75.0'),
18+
'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead (after Cloud9 VFS fixes bug)'
19+
)
20+
21+
assert.ok(
22+
semver.lt(minVscode, '1.75.0'),
23+
'remove AsyncLocalStorage polyfill used in `spans.ts` if Cloud9 is on node 14+'
24+
)
2325
})
2426

2527
it('nodejs minimum version', async function () {
26-
// const minNodejs = env.getMinNodejsVersion()
28+
const minNodejs = env.getMinNodejsVersion()
29+
2730
// XXX: available since node 16, but not sure how much work this will be, yet.
28-
// assert.ok(
29-
// semver.lt(minNodejs, '18.0.0'),
30-
// 'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'
31-
// )
31+
assert.ok(
32+
semver.lt(minNodejs, '18.0.0'),
33+
'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'
34+
)
3235
})
3336
})

0 commit comments

Comments
 (0)