Fix: filter out frequent client error from codegeneration telemetry

Author: linyuxi-0511

packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts

@@ -555,12 +555,30 @@ export class FeatureDevController {
                         result = MetricDataResult.Fault
                     }
                     break
+                case MonthlyConversationLimitError.name:
+                case CodeIterationLimitError.name:
                 case PromptRefusalException.name:
                 case NoChangeRequiredException.name:
                     result = MetricDataResult.Error
                     break
                 default:
-                    result = MetricDataResult.Fault
+                    const clinetErrorMessages = [
+                        'Improperly formed request',
+                        'Resource not found',
+                        'StartTaskAssistCodeGeneration reached for this month.',
+                        'The folder you chose did not contain any source files in a supported language. Choose another folder and try again.',
+                        'reached the quota for number of iterations on code generation.',
+                    ]
+
+                    if (
+                        (err.code === 'StartCodeGenerationFailed' &&
+                            clinetErrorMessages.slice(0, 2).some((msg) => err.message.includes(msg))) ||
+                        clinetErrorMessages.slice(2).some((msg) => err.message.includes(msg))
+                    ) {
+                        result = MetricDataResult.Error
+                    } else {
+                        result = MetricDataResult.Fault
+                    }
                     break
             }
 

packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts

@@ -471,12 +471,31 @@ describe('Controller', () => {
                 ['EmptyPatchException', MetricDataResult.LlmFailure],
                 [PromptRefusalException.name, MetricDataResult.Error],
                 [NoChangeRequiredException.name, MetricDataResult.Error],
+                [MonthlyConversationLimitError.name, MetricDataResult.Error],
+                [CodeIterationLimitError.name, MetricDataResult.Error],
             ])
 
             function getMetricResult(error: ToolkitError): MetricDataResult {
                 if (error instanceof FeatureDevServiceError && error.code) {
                     return errorResultMapping.get(error.code) ?? MetricDataResult.Error
                 }
+                if (
+                    error.code === 'StartCodeGenerationFailed' &&
+                    (error.message.includes('Improperly formed request') ||
+                        error.message.includes('Resource not found'))
+                ) {
+                    return MetricDataResult.Error
+                }
+                if (error.message.includes('StartTaskAssistCodeGeneration reached for this month.')) {
+                    return MetricDataResult.Error
+                }
+                if (
+                    error.message.includes(
+                        'The folder you chose did not contain any source files in a supported language. Choose another folder and try again.'
+                    )
+                ) {
+                    return MetricDataResult.Error
+                }
                 return errorResultMapping.get(error.constructor.name) ?? MetricDataResult.Fault
             }