Skip to content

Commit b730331

Browse files
committed
feat: enable sts invalidation
1 parent f45c92a commit b730331

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

packages/core/src/auth/auth2.ts

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import {
1212
GetIamCredentialParams,
1313
getIamCredentialRequestType,
1414
GetIamCredentialResult,
15-
InvalidateIamCredentialResult,
15+
InvalidateStsCredentialResult,
1616
IamIdentityCenterSsoTokenSource,
1717
InvalidateSsoTokenParams,
18-
InvalidateIamCredentialParams,
18+
InvalidateStsCredentialParams,
1919
invalidateSsoTokenRequestType,
20-
invalidateIamCredentialRequestType,
20+
invalidateStsCredentialRequestType,
2121
ProfileKind,
2222
UpdateProfileParams,
2323
updateProfileRequestType,
@@ -234,18 +234,18 @@ export class LanguageClientAuth {
234234
} satisfies InvalidateSsoTokenParams) as Promise<InvalidateSsoTokenResult>
235235
}
236236

237-
invalidateIamCredential(tokenId: string) {
238-
return this.client.sendRequest(invalidateIamCredentialRequestType.method, {
239-
iamCredentialsId: tokenId,
240-
} satisfies InvalidateIamCredentialParams) as Promise<InvalidateIamCredentialResult>
241-
}
242-
243237
// invalidateStsCredential(tokenId: string) {
244238
// return this.client.sendRequest(invalidateStsCredentialRequestType.method, {
245-
// stsCredentialId: tokenId,
239+
// iamCredentialsId: tokenId,
246240
// } satisfies InvalidateStsCredentialParams) as Promise<InvalidateStsCredentialResult>
247241
// }
248242

243+
invalidateStsCredential(tokenId: string) {
244+
return this.client.sendRequest(invalidateStsCredentialRequestType.method, {
245+
profileName: tokenId,
246+
} satisfies InvalidateStsCredentialParams) as Promise<InvalidateStsCredentialResult>
247+
}
248+
249249
registerSsoTokenChangedHandler(ssoTokenChangedHandler: (params: SsoTokenChangedParams) => any) {
250250
this.client.onNotification(ssoTokenChangedRequestType.method, ssoTokenChangedHandler)
251251
}
@@ -505,7 +505,7 @@ export class IamLogin extends BaseLogin {
505505

506506
async logout() {
507507
if (this.iamCredentialId) {
508-
await this.lspAuth.invalidateIamCredential(this.iamCredentialId)
508+
await this.lspAuth.invalidateStsCredential(this.iamCredentialId)
509509
}
510510
await this.lspAuth.updateIamProfile(this.profileName, '', '', '')
511511
this.updateConnectionState('notConnected')
@@ -588,19 +588,19 @@ export class IamLogin extends BaseLogin {
588588
this.cancellationToken = undefined
589589
}
590590

591-
// this.iamCredentialId = response.id
591+
this.iamCredentialId = response.id
592592
this.updateConnectionState('connected')
593593
return response
594594
}
595595

596-
// private stsCredentialChangedHandler(params: StsCredentialChangedParams) {
597-
// if (params.stsCredentialId === this.iamCredentialId) {
598-
// if (params.kind === StsCredentialChangedKind.Expired) {
599-
// this.updateConnectionState('expired')
600-
// return
601-
// } else if (params.kind === StsCredentialChangedKind.Refreshed) {
602-
// this.eventEmitter.fire({ id: this.profileName, state: 'refreshed' })
603-
// }
604-
// }
605-
// }
596+
// private stsCredentialChangedHandler(params: StsCredentialChangedParams) {
597+
// if (params.stsCredentialId === this.iamCredentialId) {
598+
// if (params.kind === StsCredentialChangedKind.Expired) {
599+
// this.updateConnectionState('expired')
600+
// return
601+
// } else if (params.kind === StsCredentialChangedKind.Refreshed) {
602+
// this.eventEmitter.fire({ id: this.profileName, state: 'refreshed' })
603+
// }
604+
// }
605+
// }
606606
}

packages/core/src/login/webview/vue/login.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@
230230

231231
<template v-if="stage === 'AUTHENTICATING'">
232232
<div class="auth-container-section">
233-
<div v-if="app === 'TOOLKIT' && profileName.length > 0" class="header bottomMargin">
233+
<div v-if="(app === 'TOOLKIT' && profileName.length > 0) || (app === 'AMAZONQ' && accessKey.length > 0)" class="header bottomMargin">
234234
Connecting to IAM...
235235
</div>
236236
<div v-else class="header bottomMargin">Authenticating in browser...</div>

0 commit comments

Comments
 (0)