telemetry: remove deprecated transform metrics #5538

tincheng · web-flow · commit b85c22314ba0 · 2024-09-11T09:12:12.000-07:00
diff --git a/packages/core/src/amazonqGumby/chat/controller/controller.ts b/packages/core/src/amazonqGumby/chat/controller/controller.ts
@@ -55,7 +55,6 @@ import { CodeTransformTelemetryState } from '../../telemetry/codeTransformTeleme
 import { getAuthType } from '../../../codewhisperer/service/transformByQ/transformApiHandler'
 import DependencyVersions from '../../models/dependencies'
 import { getStringHash } from '../../../shared/utilities/textUtilities'
-import { getTelemetryReasonDesc } from '../../../shared/errors'
 import { getVersionData } from '../../../codewhisperer/service/transformByQ/transformMavenHandler'
 
 // These events can be interactions within the chat,
@@ -255,8 +254,6 @@ export class GumbyController {
 
     private async validateProjectsWithReplyOnError(message: any): Promise<TransformationCandidateProject[]> {
         let telemetryJavaVersion = JDKToTelemetryValue(JDKVersion.UNSUPPORTED) as CodeTransformJavaSourceVersionsAllowed
-
-        let err
         try {
             const validProjects = await telemetry.codeTransform_validateProject.run(async () => {
                 telemetry.record({
@@ -288,17 +285,6 @@ export class GumbyController {
             } else {
                 this.messenger.sendUnrecoverableErrorResponse('no-project-found', message.tabID)
             }
-            err = e
-        } finally {
-            // TODO: remove deprecated metric once BI started using new metrics
-            telemetry.codeTransform_projectDetails.emit({
-                passive: true,
-                codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                codeTransformLocalJavaVersion: telemetryJavaVersion,
-                result: err?.code ? MetadataResult.Fail : MetadataResult.Pass,
-                reason: err?.code,
-                reasonDesc: getTelemetryReasonDesc(err),
-            })
         }
         return []
     }
@@ -391,20 +377,6 @@ export class GumbyController {
             )
         }
 
-        const projectPath = transformByQState.getProjectPath()
-        // TODO: remove deprecated metric once BI started using new metrics
-        telemetry.codeTransform_jobStartedCompleteFromPopupDialog.emit({
-            codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-            codeTransformJavaSourceVersionsAllowed: JDKToTelemetryValue(
-                transformByQState.getSourceJDKVersion()!
-            ) as CodeTransformJavaSourceVersionsAllowed,
-            codeTransformJavaTargetVersionsAllowed: JDKToTelemetryValue(
-                transformByQState.getTargetJDKVersion()
-            ) as CodeTransformJavaTargetVersionsAllowed,
-            codeTransformProjectId: projectPath === undefined ? telemetryUndefined : getStringHash(projectPath),
-            result: MetadataResult.Pass,
-        })
-
         // Pre-build project locally
         try {
             this.sessionStorage.getSession().conversationState = ConversationState.COMPILING
diff --git a/packages/core/src/codewhisperer/commands/startTransformByQ.ts b/packages/core/src/codewhisperer/commands/startTransformByQ.ts
@@ -120,14 +120,6 @@ async function validateJavaHome(): Promise<boolean> {
         }
     }
     if (javaVersionUsedByMaven !== transformByQState.getSourceJDKVersion()) {
-        // TODO: remove deprecated metric once BI started using new metrics
-        telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({
-            codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-            codeTransformPreValidationError: 'ProjectJDKDiffersFromBuildSystemJDK',
-            result: MetadataResult.Fail,
-            reason: `${transformByQState.getSourceJDKVersion()} (project) - ${javaVersionUsedByMaven} (maven)`,
-        })
-
         // means either javaVersionUsedByMaven is undefined or it does not match the project JDK
         return false
     }
@@ -728,10 +720,10 @@ export async function postTransformationJob() {
 
     // Note: IntelliJ implementation of ResultStatusMessage includes additional metadata such as jobId.
     telemetry.codeTransform_totalRunTime.emit({
+        buildSystemVersion: mavenVersionInfoMessage,
         codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
         codeTransformResultStatusMessage: resultStatusMessage,
         codeTransformRunTimeLatency: durationInMs,
-        codeTransformLocalMavenVersion: mavenVersionInfoMessage,
         codeTransformLocalJavaVersion: javaVersionInfoMessage,
         result: resultStatusMessage === TransformByQStatus.Succeeded ? MetadataResult.Pass : MetadataResult.Fail,
         reason: resultStatusMessage,
diff --git a/packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts b/packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts
@@ -289,12 +289,10 @@ interface ZipCodeResult {
 
 export async function zipCode({ dependenciesFolder, humanInTheLoopFlag, modulePath, zipManifest }: IZipCodeParams) {
     let tempFilePath = undefined
-    let zipStartTime = undefined
     let logFilePath = undefined
     let dependenciesCopied = false
     try {
         throwIfCancelled()
-        zipStartTime = globals.clock.Date.now()
         const zip = new AdmZip()
 
         // If no modulePath is passed in, we are not uploaded the source folder
@@ -335,11 +333,6 @@ export async function zipCode({ dependenciesFolder, humanInTheLoopFlag, modulePa
                 dependencyFilesSize += (await fs.promises.stat(file)).size
             }
             getLogger().info(`CodeTransformation: dependency files size = ${dependencyFilesSize}`)
-            // TODO: remove deprecated metric once BI started using new metrics
-            telemetry.codeTransform_dependenciesCopied.emit({
-                codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                result: MetadataResult.Pass,
-            })
             dependenciesCopied = true
         } else {
             if (zipManifest instanceof ZipManifest) {
@@ -365,11 +358,6 @@ export async function zipCode({ dependenciesFolder, humanInTheLoopFlag, modulePa
             fs.rmSync(dependenciesFolder.path, { recursive: true, force: true })
         }
     } catch (e: any) {
-        telemetry.codeTransform_logGeneralError.emit({
-            codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-            result: MetadataResult.Fail,
-            reason: 'ZipCreationFailed',
-        })
         throw Error('Failed to zip project')
     } finally {
         if (logFilePath) {
@@ -381,14 +369,6 @@ export async function zipCode({ dependenciesFolder, humanInTheLoopFlag, modulePa
 
     const exceedsLimit = zipSize > CodeWhispererConstants.uploadZipSizeLimitInBytes
 
-    // TODO: remove deprecated metric once BI started using new metrics
-    telemetry.codeTransform_jobCreateZipEndTime.emit({
-        codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-        codeTransformTotalByteSize: zipSize,
-        codeTransformRunTimeLatency: calculateTotalLatency(zipStartTime),
-        result: exceedsLimit ? MetadataResult.Fail : MetadataResult.Pass,
-    })
-
     getLogger().info(`CodeTransformation: created ZIP of size ${zipSize} at ${tempFilePath}`)
 
     if (exceedsLimit) {
diff --git a/packages/core/src/codewhisperer/service/transformByQ/transformMavenHandler.ts b/packages/core/src/codewhisperer/service/transformByQ/transformMavenHandler.ts
@@ -7,11 +7,7 @@ import { FolderInfo, transformByQState } from '../../models/model'
 import { getLogger } from '../../../shared/logger'
 import * as CodeWhispererConstants from '../../models/constants'
 import { spawnSync } from 'child_process' // Consider using ChildProcess once we finalize all spawnSync calls
-import {
-    CodeTransformBuildCommand,
-    CodeTransformMavenBuildCommand,
-    telemetry,
-} from '../../../shared/telemetry/telemetry'
+import { CodeTransformBuildCommand, telemetry } from '../../../shared/telemetry/telemetry'
 import { CodeTransformTelemetryState } from '../../../amazonqGumby/telemetry/codeTransformTelemetryState'
 import { MetadataResult } from '../../../shared/telemetry/telemetryClient'
 import { ToolkitError } from '../../../shared/errors'
@@ -81,13 +77,6 @@ function installProjectDependencies(dependenciesFolder: FolderInfo, modulePath:
                 const errorCode = (spawnResult.error as any).code ?? 'UNKNOWN'
                 errorReason += `-${errorCode}`
             }
-            // TODO: remove deprecated metric once BI started using new metrics
-            telemetry.codeTransform_mvnBuildFailed.emit({
-                codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                codeTransformMavenBuildCommand: mavenBuildCommand as CodeTransformMavenBuildCommand,
-                result: MetadataResult.Fail,
-                reason: errorReason,
-            })
 
             // Explicitly set metric as failed since no exception was caught
             telemetry.record({ result: MetadataResult.Fail, reason: errorReason })
@@ -130,9 +119,6 @@ function copyProjectDependencies(dependenciesFolder: FolderInfo, modulePath: str
         errorLog += spawnResult.error ? JSON.stringify(spawnResult.error) : ''
         errorLog += `${spawnResult.stderr}\n${spawnResult.stdout}`
         transformByQState.appendToErrorLog(`${baseCommand} copy-dependencies failed: \n ${errorLog}`)
-        getLogger().info(
-            `CodeTransformation: Maven copy-dependencies command ${baseCommand} failed, but still continuing with transformation: ${errorLog}`
-        )
         let errorReason = ''
         if (spawnResult.stdout) {
             errorReason = 'Maven Copy: CopyDependenciesExecutionError'
@@ -146,20 +132,17 @@ function copyProjectDependencies(dependenciesFolder: FolderInfo, modulePath: str
             const errorCode = (spawnResult.error as any).code ?? 'UNKNOWN'
             errorReason += `-${errorCode}`
         }
+        getLogger().info(
+            `CodeTransformation: Maven copy-dependencies command ${baseCommand} failed, but still continuing with transformation: ${errorReason}, log: ${errorLog}`
+        )
+
         let mavenBuildCommand = transformByQState.getMavenName()
         // slashes not allowed in telemetry
         if (mavenBuildCommand === './mvnw') {
             mavenBuildCommand = 'mvnw'
         } else if (mavenBuildCommand === '.\\mvnw.cmd') {
             mavenBuildCommand = 'mvnw.cmd'
         }
-        // TODO: remove deprecated metric once BI started using new metrics
-        telemetry.codeTransform_mvnBuildFailed.emit({
-            codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-            codeTransformMavenBuildCommand: mavenBuildCommand as CodeTransformMavenBuildCommand,
-            result: MetadataResult.Fail,
-            reason: errorReason,
-        })
         throw new Error('Maven copy-deps error')
     } else {
         transformByQState.appendToErrorLog(`${baseCommand} copy-dependencies succeeded`)
diff --git a/packages/core/src/codewhisperer/service/transformByQ/transformProjectValidationHandler.ts b/packages/core/src/codewhisperer/service/transformByQ/transformProjectValidationHandler.ts
@@ -7,10 +7,6 @@ import { getLogger } from '../../../shared/logger'
 import * as CodeWhispererConstants from '../../models/constants'
 import * as vscode from 'vscode'
 import { spawnSync } from 'child_process' // Consider using ChildProcess once we finalize all spawnSync calls
-import { telemetry } from '../../../shared/telemetry/telemetry'
-import { CodeTransformTelemetryState } from '../../../amazonqGumby/telemetry/codeTransformTelemetryState'
-import { javapOutputToTelemetryValue } from '../../../amazonqGumby/telemetry/codeTransformTelemetry'
-import { MetadataResult } from '../../../shared/telemetry/telemetryClient'
 import {
     NoJavaProjectsFoundError,
     NoMavenJavaProjectsFoundError,
@@ -99,16 +95,9 @@ async function getProjectsValidToTransform(
                     const errorCode = (spawnResult.error as any).code ?? 'UNKNOWN'
                     errorReason += `-${errorCode}`
                 }
-                if (!onProjectFirstOpen) {
-                    // TODO: remove deprecated metric once BI started using new metrics
-                    telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({
-                        codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                        codeTransformPreValidationError: 'NoJavaProject',
-                        codeTransformRuntimeError: errorReason,
-                        result: MetadataResult.Fail,
-                        reason: 'CannotDetermineJavaVersion',
-                    })
-                }
+                getLogger().error(
+                    `CodeTransformation: Error in running javap command = ${errorReason}, log = ${errorLog}`
+                )
             } else {
                 const majorVersionIndex = spawnResult.stdout.indexOf('major version: ')
                 const javaVersion = spawnResult.stdout.slice(majorVersionIndex + 15, majorVersionIndex + 17).trim()
@@ -118,15 +107,6 @@ async function getProjectsValidToTransform(
                     detectedJavaVersion = JDKVersion.JDK11
                 } else {
                     detectedJavaVersion = JDKVersion.UNSUPPORTED
-                    if (!onProjectFirstOpen) {
-                        // TODO: remove deprecated metric once BI started using new metrics
-                        telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({
-                            codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                            codeTransformPreValidationError: 'UnsupportedJavaVersion',
-                            result: MetadataResult.Fail,
-                            reason: javapOutputToTelemetryValue(javaVersion),
-                        })
-                    }
                 }
             }
         }
@@ -151,29 +131,13 @@ export async function validateOpenProjects(
     const javaProjects = await getJavaProjects(projects)
 
     if (javaProjects.length === 0) {
-        if (!onProjectFirstOpen) {
-            // TODO: remove deprecated metric once BI started using new metrics
-            telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({
-                codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                codeTransformPreValidationError: 'NoJavaProject',
-                result: MetadataResult.Fail,
-                reason: 'CouldNotFindJavaProject',
-            })
-        }
         throw new NoJavaProjectsFoundError()
     }
 
     const mavenJavaProjects = await getMavenJavaProjects(javaProjects)
     if (mavenJavaProjects.length === 0) {
         if (!onProjectFirstOpen) {
             void vscode.window.showErrorMessage(CodeWhispererConstants.noPomXmlFoundNotification)
-            // TODO: remove deprecated metric once BI started using new metrics
-            telemetry.codeTransform_isDoubleClickedToTriggerInvalidProject.emit({
-                codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
-                codeTransformPreValidationError: 'UnsupportedBuildSystem',
-                result: MetadataResult.Fail,
-                reason: 'NoPomFileFound',
-            })
         }
         throw new NoMavenJavaProjectsFoundError()
     }
diff --git a/packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts b/packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts
diff --git a/packages/core/src/test/techdebt.test.ts b/packages/core/src/test/techdebt.test.ts
