fix(amazonq): make cross-validating async

## Problem
https://quip-amazon.com/MOnPAkOTTGzQ/Amazon-Q-Developer-Bug-Bash-for-FRA#temp:C:aQWe6702ee5b8e6421785dd3e9eb
Profile selection page briefly appears on startup before defaulting to a
profile then going to chat. Ideally it is not shown at all

## Solution
because on project startup, before plugin finish "validating" selected
profile, `AuthUtils.requireProfileSeleciton` will return `true`
therefore the webview page will briefly appear and be gone when the
plugin receives API response.

Author: Will-ShaoHua

packages/amazonq/test/unit/codewhisperer/region/regionProfileManager.test.ts

@@ -173,13 +173,13 @@ describe('RegionProfileManager', function () {
 
             await sut.persistSelectRegionProfile()
 
-            const state = globals.globalState.tryGet<{ [label: string]: string }>(
+            const state = globals.globalState.tryGet<{ [label: string]: RegionProfile }>(
                 'aws.amazonq.regionProfiles',
                 Object,
                 {}
             )
 
-            assert.strictEqual(state[conn.id], profileFoo.arn)
+            assert.strictEqual(state[conn.id], profileFoo)
         })
 
         it(`restoreRegionProfile`, async function () {
@@ -191,7 +191,7 @@ describe('RegionProfileManager', function () {
             }
 
             const state = {} as any
-            state[conn.id] = profileFoo.arn
+            state[conn.id] = profileFoo
 
             await globals.globalState.update('aws.amazonq.regionProfiles', state)
 
@@ -212,19 +212,19 @@ describe('RegionProfileManager', function () {
                 fail('connection should not be undefined')
             }
             await sut.persistSelectRegionProfile()
-            const state = globals.globalState.tryGet<{ [label: string]: string }>(
+            const state = globals.globalState.tryGet<{ [label: string]: RegionProfile }>(
                 'aws.amazonq.regionProfiles',
                 Object,
                 {}
             )
-            assert.strictEqual(state[conn.id], profileFoo.arn)
+            assert.strictEqual(state[conn.id], profileFoo)
 
             // subject to test
             await sut.invalidateProfile(profileFoo.arn)
 
             // assertion
             assert.strictEqual(sut.activeRegionProfile, undefined)
-            const actualGlobalState = globals.globalState.tryGet<{ [label: string]: string }>(
+            const actualGlobalState = globals.globalState.tryGet<{ [label: string]: RegionProfile }>(
                 'aws.amazonq.regionProfiles',
                 Object,
                 {}

packages/core/src/codewhisperer/region/regionProfileManager.ts

@@ -235,36 +235,37 @@ export class RegionProfileManager {
             return
         }
         // cross-validation
-        let profiles: RegionProfile[] = []
-        try {
-            profiles = await this.listRegionProfile()
-        } catch (e) {
-            telemetry.amazonq_profileState.emit({
-                source: 'reload',
-                amazonQProfileRegion: 'not-set',
-                reason: (e as Error).message,
-                result: 'Failed',
-            })
-
-            return
-        }
+        this.listRegionProfile()
+            .then(async (profiles) => {
+                const r = profiles.find((it) => it.arn === previousSelected.arn)
+                if (!r) {
+                    telemetry.amazonq_profileState.emit({
+                        source: 'reload',
+                        amazonQProfileRegion: 'not-set',
+                        reason: 'profile could not be selected',
+                        result: 'Failed',
+                    })
 
-        const r = profiles.find((it) => it.arn === previousSelected)
-        if (!r) {
-            telemetry.amazonq_profileState.emit({
-                source: 'reload',
-                amazonQProfileRegion: 'not-set',
-                reason: 'profile could not be selected',
-                result: 'Failed',
+                    await this.invalidateProfile(previousSelected.arn)
+                    RegionProfileManager.logger.warn(
+                        `invlaidating ${previousSelected.name} profile, arn=${previousSelected.arn}`
+                    )
+                }
+            })
+            .catch((e) => {
+                telemetry.amazonq_profileState.emit({
+                    source: 'reload',
+                    amazonQProfileRegion: 'not-set',
+                    reason: (e as Error).message,
+                    result: 'Failed',
+                })
             })
-            return
-        }
 
-        await this.switchRegionProfile(r, 'reload')
+        await this.switchRegionProfile(previousSelected, 'reload')
     }
 
-    private loadPersistedRegionProfle(): { [label: string]: string } {
-        const previousPersistedState = globals.globalState.tryGet<{ [label: string]: string }>(
+    private loadPersistedRegionProfle(): { [label: string]: RegionProfile } {
+        const previousPersistedState = globals.globalState.tryGet<{ [label: string]: RegionProfile }>(
             'aws.amazonq.regionProfiles',
             Object,
             {}
@@ -282,13 +283,13 @@ export class RegionProfileManager {
         }
 
         // persist connectionId to profileArn
-        const previousPersistedState = globals.globalState.tryGet<{ [label: string]: string }>(
+        const previousPersistedState = globals.globalState.tryGet<{ [label: string]: RegionProfile }>(
             'aws.amazonq.regionProfiles',
             Object,
             {}
         )
 
-        previousPersistedState[conn.id] = this.activeRegionProfile.arn
+        previousPersistedState[conn.id] = this.activeRegionProfile
         await globals.globalState.update('aws.amazonq.regionProfiles', previousPersistedState)
     }
 
@@ -337,7 +338,7 @@ export class RegionProfileManager {
 
             const profiles = this.loadPersistedRegionProfle()
             const updatedProfiles = Object.fromEntries(
-                Object.entries(profiles).filter(([connId, profileArn]) => profileArn !== arn)
+                Object.entries(profiles).filter(([connId, profile]) => profile.arn !== arn)
             )
             await globals.globalState.update('aws.amazonq.regionProfiles', updatedProfiles)
         }