Using AB variation value as customization name when overridden

Author: spfink

packages/amazonq/.changes/next-release/Feature-7ffbdb5d-40c5-4c3e-bc20-63d731bc51d2.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "Uses AB variation as the name for overridden customizations"
+}

packages/core/src/codewhisperer/util/customizationUtil.ts

@@ -109,14 +109,15 @@ export const getSelectedCustomization = (): Customization => {
 
     // A/B case
     const arnOverride = FeatureConfigProvider.instance.getCustomizationArnOverride()
+    const customizationOverrideName = FeatureConfigProvider.instance.getCustomizationArnOverrideName()
     if (arnOverride === undefined || arnOverride === '') {
         return result
     } else {
         // A trick to prioritize arn from A/B over user's currently selected(for request and telemetry)
         // but still shows customization info of user's currently selected.
         return {
             arn: arnOverride,
-            name: result.name,
+            name: customizationOverrideName,
             description: result.description,
         }
     }

packages/core/src/shared/featureConfig.ts

@@ -9,6 +9,7 @@ import {
     ListFeatureEvaluationsRequest,
     ListFeatureEvaluationsResponse,
 } from '../codewhisperer/client/codewhispereruserclient'
+import * as vscode from 'vscode'
 import { codeWhispererClient as client } from '../codewhisperer/client/codewhisperer'
 import { AuthUtil } from '../codewhisperer/util/authUtil'
 import { getLogger } from './logger'
@@ -152,6 +153,8 @@ export class FeatureConfigProvider {
                         )
                         this.featureConfigs.delete(Features.customizationArnOverride)
                     }
+
+                    await vscode.commands.executeCommand('aws.amazonq.refreshStatusBar')
                 }
             }
             if (Auth.instance.isInternalAmazonUser()) {
@@ -195,12 +198,22 @@ export class FeatureConfigProvider {
         return this.getFeatureValueForKey(Features.customizationArnOverride).stringValue
     }
 
+    getCustomizationArnOverrideName(): string | undefined {
+        return this.getFeatureVariationForKey(Features.customizationArnOverride)
+    }
+
     // Get the feature value for the given key.
     // In case of a misconfiguration, it will return a default feature value of Boolean true.
     private getFeatureValueForKey(name: FeatureName): FeatureValue {
         return this.featureConfigs.get(name)?.value ?? featureDefinitions.get(name)?.value ?? { boolValue: true }
     }
 
+    // Get the feature variation for the given key.
+    // In case of a misconfiguration, it will return an empty string
+    private getFeatureVariationForKey(name: FeatureName): string {
+        return this.featureConfigs.get(name)?.variation ?? featureDefinitions.get(name)?.variation ?? ''
+    }
+
     /**
      * Map of feature configurations.
      *

packages/core/src/test/fake/mockFeatureConfigData.ts

@@ -21,4 +21,9 @@ export const mockFeatureConfigsData: FeatureEvaluation[] = [
         variation: 'TREATMENT',
         value: { stringValue: 'testValue' },
     },
+    {
+        feature: 'customizationArnOverride',
+        variation: 'customizationName',
+        value: { stringValue: 'customizationARN' },
+    },
 ]

packages/core/src/test/shared/featureConfig.test.ts

@@ -48,7 +48,7 @@ describe('FeatureConfigProvider', () => {
     it('test getFeatureConfigsTelemetry will return expected string', async () => {
         assert.strictEqual(
             FeatureConfigProvider.instance.getFeatureConfigsTelemetry(),
-            `{testFeature: TREATMENT, featureA: CONTROL, featureB: TREATMENT}`
+            `{testFeature: TREATMENT, featureA: CONTROL, featureB: TREATMENT, customizationArnOverride: customizationName}`
         )
     })
 
@@ -77,6 +77,13 @@ describe('FeatureConfigProvider', () => {
                     },
                     variation: 'TREATMENT',
                 },
+                customizationArnOverride: {
+                    name: 'customizationArnOverride',
+                    value: {
+                        stringValue: 'customizationARN',
+                    },
+                    variation: 'customizationName',
+                },
             }
 
             assert.deepStrictEqual(Object.fromEntries(featureConfigs), expectedFeatureConfigs)
@@ -95,6 +102,11 @@ describe('FeatureConfigProvider', () => {
         assert.strictEqual(FeatureConfigProvider.isEnabled('feature-does-not-exist' as FeatureName), false)
     })
 
+    it('should retrieve customization override values', async () => {
+        assert.strictEqual(FeatureConfigProvider.instance.getCustomizationArnOverrideName(), 'customizationName')
+        assert.strictEqual(FeatureConfigProvider.instance.getCustomizationArnOverride(), 'customizationARN')
+    })
+
     describe('getProjectContextGroup', function () {
         beforeEach(function () {
             sinon.restore()