fix the test

Author: Randall-Jiang

packages/core/src/codewhispererChat/tools/executeBash.ts

@@ -189,24 +189,24 @@ export class ExecuteBash {
                 if (cmdArgs.length === 0) {
                     return { requiresAcceptance: true }
                 }
-
+                let hasOutsideWorkspacePath = false
                 // For each command, validate arguments for path safety within workspace
                 for (const arg of cmdArgs) {
                     if (this.looksLikePath(arg)) {
-                        // If not absolute, resolve using workingDirectory if available.
                         let fullPath = arg
                         if (!path.isAbsolute(arg) && this.workingDirectory) {
                             fullPath = path.join(this.workingDirectory, arg)
                         }
                         const workspaceFolders = vscode.workspace.workspaceFolders
                         if (!workspaceFolders || workspaceFolders.length === 0) {
-                            return { requiresAcceptance: true }
+                            hasOutsideWorkspacePath = true
+                            continue
                         }
                         const isInWorkspace = workspaceFolders.some((folder) =>
                             isInDirectory(folder.uri.fsPath, fullPath)
                         )
                         if (!isInWorkspace) {
-                            return { requiresAcceptance: true }
+                            hasOutsideWorkspacePath = true
                         }
                     }
                 }
@@ -216,10 +216,19 @@ export class ExecuteBash {
 
                 switch (category) {
                     case CommandCategory.Destructive:
-                        return { requiresAcceptance: true, warning: destructiveCommandWarningMessage }
+                        return {
+                            requiresAcceptance: true,
+                            warning: destructiveCommandWarningMessage,
+                        }
                     case CommandCategory.Mutate:
-                        return { requiresAcceptance: true, warning: mutateCommandWarningMessage }
+                        return {
+                            requiresAcceptance: true,
+                            warning: mutateCommandWarningMessage,
+                        }
                     case CommandCategory.ReadOnly:
+                        if (hasOutsideWorkspacePath) {
+                            return { requiresAcceptance: true }
+                        }
                         continue
                     default:
                         return { requiresAcceptance: true }

packages/core/src/test/codewhispererChat/tools/executeBash.test.ts

@@ -44,7 +44,7 @@ describe('ExecuteBash Tool', () => {
     })
 
     it('set requiresAcceptance=true if the command has dangerous patterns', () => {
-        const execBash = new ExecuteBash({ command: 'rm -rf /' })
+        const execBash = new ExecuteBash({ command: 'ls && rm -rf /' })
         const needsAcceptance = execBash.requiresAcceptance().requiresAcceptance
         assert.equal(needsAcceptance, true, 'Should require acceptance for dangerous pattern')
         assert.equal(