fix(smus): Space metadata is stale after the updateSpace call (#2213)

## Problem
Consistently reproducing a similar issue when attempting to
start/connect to a Stopped Space when remote access is initially
disabled. The Space is updated, started, and even connected to, but the
Space does not show the Connect button anymore, until the Project is
refreshed. This suggests the Space metadata is stale after the
UpdateSpace call.

## Solution
Tried to simply replace the spaceApp variable with the updated one got
from describeSpace API call, but find conflicts on variable definitions.
so update the variable names and update only remoteAccess variable to
minimize impact.

ListSpaces(original)

https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/sagemaker/command/ListSpacesCommand/

<img width="2556" height="1308" alt="Screenshot 2025-09-01 at 4 11
09 PM"
src="https://github.com/user-attachments/assets/64b4439e-4495-4822-9a56-c61470e269c6"
/>

DescribeSpace(updated)

https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-client-sagemaker/Interface/DescribeSpaceCommandOutput/
<img width="2523" height="1299" alt="Screenshot 2025-09-01 at 5 02
24 PM"
src="https://github.com/user-attachments/assets/37860497-8116-4d16-bc08-2562d0ea25bd"
/>

- pass SpaceSettingsSummary -> SpaceSettings in spaceApp type parameter 

- update remote access 
## Test 

manually debug and unit test

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

Co-authored-by: Laxman Reddy <[email protected]>

Author: PotatoWKY

packages/core/src/awsService/sagemaker/sagemakerSpace.ts

@@ -33,6 +33,10 @@ export class SagemakerSpace {
 
     public updateSpace(spaceApp: SagemakerSpaceApp) {
         this.setSpaceStatus(spaceApp.Status ?? '', spaceApp.App?.Status ?? '')
+        // Only update RemoteAccess property to minimize impact due to minor structural differences between variables
+        if (this.spaceApp.SpaceSettingsSummary && spaceApp.SpaceSettingsSummary?.RemoteAccess) {
+            this.spaceApp.SpaceSettingsSummary.RemoteAccess = spaceApp.SpaceSettingsSummary.RemoteAccess
+        }
         this.label = this.buildLabel()
         this.description = this.isSMUSSpace ? undefined : this.buildDescription()
         this.tooltip = new vscode.MarkdownString(this.buildTooltip())
@@ -109,8 +113,20 @@ export class SagemakerSpace {
             SpaceName: this.spaceApp.SpaceName,
         })
 
+        // AWS DescribeSpace API returns full details with property names like 'SpaceSettings'
+        // but our internal SagemakerSpaceApp type expects 'SpaceSettingsSummary' (from ListSpaces API)
+        // We destructure and rename properties to maintain type compatibility
+        const {
+            SpaceSettings: spaceSettingsSummary,
+            OwnershipSettings: ownershipSettingsSummary,
+            SpaceSharingSettings: spaceSharingSettingsSummary,
+            ...spaceDetails
+        } = space
         this.updateSpace({
-            ...space,
+            SpaceSettingsSummary: spaceSettingsSummary,
+            OwnershipSettingsSummary: ownershipSettingsSummary,
+            SpaceSharingSettingsSummary: spaceSharingSettingsSummary,
+            ...spaceDetails,
             App: app,
             DomainSpaceKey: this.spaceApp.DomainSpaceKey,
         })

packages/core/src/test/awsService/sagemaker/sagemakerSpace.test.ts

@@ -0,0 +1,129 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import assert from 'assert'
+import { SagemakerSpace } from '../../../awsService/sagemaker/sagemakerSpace'
+import { SagemakerClient, SagemakerSpaceApp } from '../../../shared/clients/sagemaker'
+import sinon from 'sinon'
+
+describe('SagemakerSpace', function () {
+    let mockClient: sinon.SinonStubbedInstance<SagemakerClient>
+    let mockSpaceApp: SagemakerSpaceApp
+
+    beforeEach(function () {
+        mockClient = sinon.createStubInstance(SagemakerClient)
+        mockSpaceApp = {
+            SpaceName: 'test-space',
+            Status: 'InService',
+            DomainId: 'test-domain',
+            DomainSpaceKey: 'test-key',
+            SpaceSettingsSummary: {
+                AppType: 'JupyterLab',
+                RemoteAccess: 'ENABLED',
+            },
+        }
+    })
+
+    afterEach(function () {
+        sinon.restore()
+    })
+
+    describe('updateSpaceAppStatus', function () {
+        it('should correctly map DescribeSpace API response to SagemakerSpaceApp type', async function () {
+            // Mock DescribeSpace response (uses full property names)
+            const mockDescribeSpaceResponse = {
+                SpaceName: 'updated-space',
+                Status: 'InService',
+                DomainId: 'test-domain',
+                SpaceSettings: {
+                    // Note: 'SpaceSettings' not 'SpaceSettingsSummary'
+                    AppType: 'CodeEditor',
+                    RemoteAccess: 'DISABLED',
+                },
+                OwnershipSettings: {
+                    OwnerUserProfileName: 'test-user',
+                },
+                SpaceSharingSettings: {
+                    SharingType: 'Private',
+                },
+                $metadata: { requestId: 'test-request-id' },
+            }
+
+            // Mock DescribeApp response
+            const mockDescribeAppResponse = {
+                AppName: 'test-app',
+                Status: 'InService',
+                ResourceSpec: {
+                    InstanceType: 'ml.t3.medium',
+                },
+                $metadata: { requestId: 'test-request-id' },
+            }
+
+            mockClient.describeSpace.resolves(mockDescribeSpaceResponse)
+            mockClient.describeApp.resolves(mockDescribeAppResponse)
+
+            const space = new SagemakerSpace(mockClient as any, 'us-east-1', mockSpaceApp)
+            const updateSpaceSpy = sinon.spy(space, 'updateSpace')
+
+            await space.updateSpaceAppStatus()
+
+            // Verify updateSpace was called with correctly mapped properties
+            assert.ok(updateSpaceSpy.calledOnce)
+            const updateSpaceArgs = updateSpaceSpy.getCall(0).args[0]
+
+            // Verify property name mapping from DescribeSpace to SagemakerSpaceApp
+            assert.strictEqual(updateSpaceArgs.SpaceSettingsSummary?.AppType, 'CodeEditor')
+            assert.strictEqual(updateSpaceArgs.SpaceSettingsSummary?.RemoteAccess, 'DISABLED')
+            assert.strictEqual(updateSpaceArgs.OwnershipSettingsSummary?.OwnerUserProfileName, 'test-user')
+            assert.strictEqual(updateSpaceArgs.SpaceSharingSettingsSummary?.SharingType, 'Private')
+
+            // Verify other properties are preserved
+            assert.strictEqual(updateSpaceArgs.SpaceName, 'updated-space')
+            assert.strictEqual(updateSpaceArgs.Status, 'InService')
+            assert.strictEqual(updateSpaceArgs.DomainId, 'test-domain')
+            assert.strictEqual(updateSpaceArgs.App, mockDescribeAppResponse)
+            assert.strictEqual(updateSpaceArgs.DomainSpaceKey, 'test-key')
+
+            // Verify original API property names are not present
+            assert.ok(!('SpaceSettings' in updateSpaceArgs))
+            assert.ok(!('OwnershipSettings' in updateSpaceArgs))
+            assert.ok(!('SpaceSharingSettings' in updateSpaceArgs))
+        })
+
+        it('should handle missing optional properties gracefully', async function () {
+            // Mock minimal DescribeSpace response
+            const mockDescribeSpaceResponse = {
+                SpaceName: 'minimal-space',
+                Status: 'InService',
+                DomainId: 'test-domain',
+                $metadata: { requestId: 'test-request-id' },
+                // No SpaceSettings, OwnershipSettings, or SpaceSharingSettings
+            }
+
+            const mockDescribeAppResponse = {
+                AppName: 'test-app',
+                Status: 'InService',
+                $metadata: { requestId: 'test-request-id' },
+            }
+
+            mockClient.describeSpace.resolves(mockDescribeSpaceResponse)
+            mockClient.describeApp.resolves(mockDescribeAppResponse)
+
+            const space = new SagemakerSpace(mockClient as any, 'us-east-1', mockSpaceApp)
+            const updateSpaceSpy = sinon.spy(space, 'updateSpace')
+
+            await space.updateSpaceAppStatus()
+
+            // Should not throw and should handle undefined properties
+            assert.ok(updateSpaceSpy.calledOnce)
+            const updateSpaceArgs = updateSpaceSpy.getCall(0).args[0]
+
+            assert.strictEqual(updateSpaceArgs.SpaceName, 'minimal-space')
+            assert.strictEqual(updateSpaceArgs.SpaceSettingsSummary, undefined)
+            assert.strictEqual(updateSpaceArgs.OwnershipSettingsSummary, undefined)
+            assert.strictEqual(updateSpaceArgs.SpaceSharingSettingsSummary, undefined)
+        })
+    })
+})