fix(lambda): drop template path from sam deploy command #5912

## Problem
Explicitly specifying template path in sam deploy command to point to
the build artifact folder makes SAM CLI create/update `samconfig.toml`
in the build artifact folder rather than updating the `samconfig.toml`
file in project root folder.

## Solution
Remove the `--template-path` from deploy flag. SAM will determine the
template in the project folder and write to correct samconfig file

Author: vicheey

packages/core/src/shared/sam/deploy.ts

@@ -377,10 +377,6 @@ export async function runDeploy(arg: any, wizardParams?: DeployParams): Promise<
                 throw ToolkitError.chain(error, 'Failed to build SAM template', { details: { ...buildFlags } })
             }
 
-            // Pass built template to deployFlags
-            const templatePath = vscode.Uri.joinPath(params.projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath
-            deployFlags.push('--template-file', `${templatePath}`)
-
             // Create a child process to run the SAM deploy command
             const deployProcess = new ChildProcess(samCliPath, ['deploy', ...deployFlags], {
                 spawnOptions: await addTelemetryEnvVar({

packages/core/src/test/shared/sam/deploy.test.ts

@@ -709,8 +709,6 @@ describe('SAM Deploy', () => {
                     '--parameter-overrides',
                     `ParameterKey=SourceBucketName,ParameterValue=${mockDeployParams.SourceBucketName} ` +
                         `ParameterKey=DestinationBucketName,ParameterValue=${mockDeployParams.DestinationBucketName}`,
-                    '--template-file',
-                    vscode.Uri.joinPath(projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
                 ],
                 {
                     spawnOptions: {
@@ -787,8 +785,6 @@ describe('SAM Deploy', () => {
                     '--parameter-overrides',
                     `ParameterKey=SourceBucketName,ParameterValue=${mockDeployParams.SourceBucketName} ` +
                         `ParameterKey=DestinationBucketName,ParameterValue=${mockDeployParams.DestinationBucketName}`,
-                    '--template-file',
-                    vscode.Uri.joinPath(projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
                 ],
                 {
                     spawnOptions: {
@@ -867,8 +863,6 @@ describe('SAM Deploy', () => {
                     '--parameter-overrides',
                     `ParameterKey=SourceBucketName,ParameterValue=${mockDeployParams.SourceBucketName} ` +
                         `ParameterKey=DestinationBucketName,ParameterValue=${mockDeployParams.DestinationBucketName}`,
-                    '--template-file',
-                    vscode.Uri.joinPath(projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
                 ],
                 {
                     spawnOptions: {

packages/core/src/testInteg/sam.test.ts

@@ -883,8 +883,6 @@ describe('SAM Integration Tests', async function () {
                 '--capabilities',
                 'CAPABILITY_IAM',
                 'CAPABILITY_NAMED_IAM',
-                '--template-file',
-                vscode.Uri.joinPath(mockDeployParams.projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
             ])
 
             // Check that runInTerminal is called with the correct arguments for deploy

packages/toolkit/.changes/next-release/Bug Fix-1ade44c5-bd1f-4b8f-a7f3-f2740ebb8097.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "SAM: Save SAM deploy parameters to correct samconfig.toml in project folder"
+}