add tests for path utility;

Author: Hweinstock

packages/core/src/test/shared/utilities/testUtil.test.ts

@@ -0,0 +1,28 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+import assert from 'assert'
+import { createTestWorkspaceFolder, readEnvPath, withEnvPath } from '../../testUtil'
+
+describe('withEnvPath', function () {
+    it('resets path when error in task', async function () {
+        const originalPath = readEnvPath()
+        const tempFolder = await createTestWorkspaceFolder()
+        try {
+            await withEnvPath(tempFolder.uri.fsPath, async () => {
+                throw new Error()
+            })
+        } catch {}
+        assert.strictEqual(readEnvPath(), originalPath)
+    })
+
+    it('changes $PATH temporarily', async function () {
+        const originalPath = readEnvPath()
+        const tempFolder = await createTestWorkspaceFolder()
+        await withEnvPath(tempFolder.uri.fsPath, async () => {
+            assert.strictEqual(readEnvPath(), tempFolder.uri.fsPath)
+        })
+        assert.strictEqual(readEnvPath(), originalPath)
+    })
+})

packages/core/src/test/testUtil.ts

@@ -615,11 +615,11 @@ export function getFetchStubWithResponse(response: Partial<Response>) {
     return stub(request, 'fetch').returns({ response: new Promise((res, _) => res(response)) } as any)
 }
 
-function setPath(newPath: string): void {
+export function setEnvPath(newPath: string): void {
     process.env.PATH = newPath
 }
 
-function readPath(): string {
+export function readEnvPath(): string {
     return process.env.PATH || ''
 }
 /**
@@ -628,11 +628,11 @@ function readPath(): string {
  * @param task work to be done with $PATH set.
  */
 export async function withEnvPath(newPath: string, task: () => Promise<void>): Promise<void | never> {
-    const originalPath = readPath()
-    setPath(newPath)
+    const originalPath = readEnvPath()
+    setEnvPath(newPath)
     try {
         await task()
     } finally {
-        setPath(originalPath)
+        setEnvPath(originalPath)
     }
 }