deps: more-precise version of @types/node #5801

Hweinstock · web-flow · commit c44fa30adfc3 · 2024-10-17T15:11:05.000-07:00
## Problem Follow up to: #5761 (comment) ## Solution - target a version of `@types/node` that is closer to the actual version running in CI. - add a techdebt.test.ts reminder.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -69,7 +69,7 @@
         "webpack-merge": "^5.10.0"
     },
     "dependencies": {
-        "@types/node": "^22.7.5",
+        "@types/node": "^18.19.55",
         "vscode-nls": "^5.2.0",
         "vscode-nls-dev": "^4.0.4"
     }
diff --git a/packages/core/src/test/techdebt.test.ts b/packages/core/src/test/techdebt.test.ts
@@ -35,6 +35,8 @@ describe('tech debt', function () {
             semver.lt(minNodejs, '18.0.0'),
             'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'
         )
+        // This is relevant for the use of `fs.cpSync` in the copyFiles scripts.
+        assert.ok(semver.lt(minNodejs, '18.0.0'), 'with node18+, we can remove the dependency on @types/node@18')
     })
 
     it('remove separate sessions login edge cases', async function () {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@`
`69`	`69`	`"webpack-merge": "^5.10.0"`
`70`	`70`	`},`
`71`	`71`	`"dependencies": {`
`72`		`- "@types/node": "^22.7.5",`
	`72`	`+ "@types/node": "^18.19.55",`
`73`	`73`	`"vscode-nls": "^5.2.0",`
`74`	`74`	`"vscode-nls-dev": "^4.0.4"`
`75`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ describe('tech debt', function () {`
`35`	`35`	`semver.lt(minNodejs, '18.0.0'),`
`36`	`36`	`'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'`
`37`	`37`	`)`
	`38`	+ // This is relevant for the use of `fs.cpSync` in the copyFiles scripts.
	`39`	`+ assert.ok(semver.lt(minNodejs, '18.0.0'), 'with node18+, we can remove the dependency on @types/node@18')`
`38`	`40`	`})`
`39`	`41`
`40`	`42`	`it('remove separate sessions login edge cases', async function () {`