Show manifest deprecatation message in logs and ui

Author: tomzu

packages/core/src/shared/lsp/manifestResolver.ts

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import * as vscode from 'vscode'
 import { getLogger } from '../logger/logger'
 import { ToolkitError } from '../errors'
 import { Timeout } from '../utilities/timeoutUtils'
@@ -60,7 +61,9 @@ export class ManifestResolver {
         }).getNewETagContent(this.getEtag())
 
         if (!resp.content) {
-            throw new ToolkitError('New content was not downloaded; fallback to the locally stored manifest')
+            throw new ToolkitError(
+                `New content was not downloaded; fallback to the locally stored ${this.lsName} manifest`
+            )
         }
 
         const manifest = this.parseManifest(resp.content)
@@ -71,12 +74,12 @@ export class ManifestResolver {
     }
 
     private async getLocalManifest(): Promise<Manifest> {
-        logger.info('Failed to download latest LSP manifest. Falling back to local manifest.')
+        logger.info(`Failed to download latest ${this.lsName} manifest. Falling back to local manifest.`)
         const storage = this.getStorage()
         const manifestData = storage[this.lsName]
 
         if (!manifestData?.content) {
-            throw new ToolkitError('Failed to download LSP manifest and no local manifest found.')
+            throw new ToolkitError(`Failed to download ${this.lsName} manifest and no local manifest found.`)
         }
 
         const manifest = this.parseManifest(manifestData.content)
@@ -90,14 +93,16 @@ export class ManifestResolver {
             return JSON.parse(content) as Manifest
         } catch (error) {
             throw new ToolkitError(
-                `Failed to parse manifest: ${error instanceof Error ? error.message : 'Unknown error'}`
+                `Failed to parse ${this.lsName} manifest: ${error instanceof Error ? error.message : 'Unknown error'}`
             )
         }
     }
 
     private checkDeprecation(manifest: Manifest): void {
         if (manifest.isManifestDeprecated) {
-            logger.info('This LSP manifest is deprecated. No future updates will be available.')
+            const deprecationMessage = `${this.lsName} manifest is deprecated. No future updates will be available.`
+            logger.info(deprecationMessage)
+            void vscode.window.showInformationMessage(deprecationMessage)
         }
     }