update sam utils test

Author: vicheey

packages/core/src/test/shared/sam/utils.test.ts

@@ -236,6 +236,10 @@ describe('SAM utils', async function () {
         const value1 = 'myStackName'
         const value2 = 'myBucketName'
 
+        after(async () => {
+            await globals.context.workspaceState.update(mementoRootKey, {})
+        })
+
         it('1. getRecentResponse should return undefined when mementoRootKey does not exist', async () => {
             assert(!getRecentResponse(nonExistingMementoRootKey, identifier, key1))
         })
@@ -244,7 +248,7 @@ describe('SAM utils', async function () {
             try {
                 await updateRecentResponse(mementoRootKey, identifier, key1, value1)
             } catch (err) {
-                assert.fail('Should have succeed')
+                assert.fail('The execution should have succeeded yet encounter unexpected exception')
             }
         })
 
@@ -261,12 +265,12 @@ describe('SAM utils', async function () {
             assert.strictEqual(result2, value2)
         })
 
-        it('5. updateRecentResponse should log when failed to update value', async () => {
+        it('5. updateRecentResponse should log and swallow exception when fails to update value', async () => {
             sinon.stub(globals.context.workspaceState, 'update').rejects(new Error('Error updating value'))
             try {
                 await updateRecentResponse(mementoRootKey, identifier, key2, value2)
             } catch (err) {
-                assert.fail('Should have swallowed exception')
+                assert.fail('The target function should have handled exception internally')
             }
             assertLogsContain(`sam: unable to save response at key`, false, 'warn')
             sinon.restore()

packages/core/src/test/shared/ui/sam/stackPrompter.test.ts

@@ -80,7 +80,7 @@ describe('createStackPrompter', () => {
             .returns(vscode.Uri.parse(`https://us-east-1.console.aws.amazon.com/cloudformation/home?region=us-east-1`))
 
         // Act
-        const prompter = createStackPrompter(cfnClient, mementoRootKey)
+        const prompter = createStackPrompter(cfnClient, mementoRootKey, samSyncUrl)
         await new Promise((f) => setTimeout(f, 50))
 
         // Assert
@@ -107,7 +107,7 @@ describe('createStackPrompter', () => {
             .returns(vscode.Uri.parse(`https://us-east-1.console.aws.amazon.com/cloudformation/home?region=us-east-1`))
 
         // Act
-        const prompter = createStackPrompter(cfnClient, mementoRootKey)
+        const prompter = createStackPrompter(cfnClient, mementoRootKey, samSyncUrl)
         await new Promise((f) => setTimeout(f, 50))
 
         // Assert