Skip to content

Commit c87f980

Browse files
authored
refactor: cleanup feature dev imports in transform (#5395)
1 parent b7855c8 commit c87f980

File tree

6 files changed

+22
-21
lines changed

6 files changed

+22
-21
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
/*!
2+
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
// Currently importing ChatItemType in Mynah UI from the vscode side causes an error
7+
// TODO remove this once the import stops failing
8+
export type ChatItemType =
9+
| 'prompt'
10+
| 'system-prompt'
11+
| 'ai-prompt'
12+
| 'answer'
13+
| 'answer-stream'
14+
| 'answer-part'
15+
| 'code-result'

packages/core/src/amazonqFeatureDev/models.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,6 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
// Currently importing ChatItemType in Mynah UI from the vscode side causes an error
7-
// TODO remove this once the import stops failing
8-
export type ChatItemType =
9-
| 'prompt'
10-
| 'system-prompt'
11-
| 'ai-prompt'
12-
| 'answer'
13-
| 'answer-stream'
14-
| 'answer-part'
15-
| 'code-result'
16-
176
export interface IManifestFile {
187
pomArtifactId: string
198
pomFolderName: string

packages/core/src/amazonqFeatureDev/views/connector/connector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import { AuthFollowUpType } from '../../../amazonq/auth/model'
77
import { MessagePublisher } from '../../../amazonq/messages/messagePublisher'
88
import { CodeReference } from '../../../amazonq/webview/ui/connector'
99
import { featureDevChat, licenseText } from '../../constants'
10-
import { ChatItemType } from '../../models'
1110
import { ChatItemAction, SourceLink } from '@aws/mynah-ui'
1211
import { DeletedFileInfo, NewFileInfo } from '../../types'
12+
import { ChatItemType } from '../../../amazonq/commons/model'
1313

1414
class UiMessage {
1515
readonly time: number = Date.now()

packages/core/src/amazonqGumby/app.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,14 @@ export function init(appContext: AmazonQAppInitContext) {
3939

4040
new GumbyController(gumbyChatControllerEventEmitters, messenger, appContext.onDidChangeAmazonQVisibility.event)
4141

42-
const featureDevChatUIInputEventEmitter = new vscode.EventEmitter<any>()
42+
const gumbyChatUIInputEventEmitter = new vscode.EventEmitter<any>()
4343

4444
new UIMessageListener({
4545
chatControllerEventEmitters: gumbyChatControllerEventEmitters,
46-
webViewMessageListener: new MessageListener<any>(featureDevChatUIInputEventEmitter),
46+
webViewMessageListener: new MessageListener<any>(gumbyChatUIInputEventEmitter),
4747
})
4848

49-
appContext.registerWebViewToAppMessagePublisher(
50-
new MessagePublisher<any>(featureDevChatUIInputEventEmitter),
51-
'gumby'
52-
)
49+
appContext.registerWebViewToAppMessagePublisher(new MessagePublisher<any>(gumbyChatUIInputEventEmitter), 'gumby')
5350

5451
const debouncedEvent = debounce(async () => {
5552
const authenticated = (await AuthUtil.instance.getChatAuthState()).amazonQ === 'connected'

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*/
1010

1111
import { AuthFollowUpType, AuthMessageDataMap } from '../../../../amazonq/auth/model'
12-
import { ChatItemType } from '../../../../amazonqFeatureDev/models'
1312
import { JDKVersion, TransformationCandidateProject, transformByQState } from '../../../../codewhisperer/models/model'
1413
import { FeatureAuthState } from '../../../../codewhisperer/util/authUtil'
1514
import * as CodeWhispererConstants from '../../../../codewhisperer/models/constants'
@@ -28,6 +27,7 @@ import {
2827
import { ChatItemButton, ChatItemFormItem } from '@aws/mynah-ui/dist/static'
2928
import MessengerUtils, { ButtonActions } from './messengerUtils'
3029
import DependencyVersions from '../../../models/dependencies'
30+
import { ChatItemType } from '../../../../amazonq/commons/model'
3131

3232
export type StaticTextResponseType =
3333
| 'transform'

packages/core/src/amazonqGumby/chat/views/connector/connector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
import { gumbyChat } from '../../../models/constants'
77
import { AuthFollowUpType } from '../../../../amazonq/auth/model'
88
import { MessagePublisher } from '../../../../amazonq/messages/messagePublisher'
9-
import { ChatItemType } from '../../../../amazonqFeatureDev/models'
109
import { ChatItemButton, ChatItemFormItem } from '@aws/mynah-ui/dist/static'
1110
import { GumbyCommands } from '../../controller/messenger/messengerUtils'
11+
import { ChatItemType } from '../../../../amazonq/commons/model'
1212

1313
export type GumbyMessageType =
1414
| 'errorMessage'
@@ -72,7 +72,7 @@ export class AuthenticationUpdateMessage {
7272
readonly type: GumbyMessageType = 'authenticationUpdateMessage'
7373

7474
constructor(
75-
readonly featureDevEnabled: boolean,
75+
readonly gumbyEnabled: boolean,
7676
readonly authenticatingTabIDs: string[]
7777
) {}
7878
}

0 commit comments

Comments
 (0)