minor fix

Author: jguoamz

packages/core/src/codewhispererChat/tools/listDirectory.ts

@@ -29,6 +29,9 @@ export class ListDirectory {
         if (!this.fsPath || this.fsPath.trim().length === 0) {
             throw new Error('Path cannot be empty.')
         }
+        if (this.maxDepth !== undefined && this.maxDepth < 0) {
+            throw new Error('MaxDepth cannot be negative.')
+        }
 
         const sanitized = sanitizePath(this.fsPath)
         this.fsPath = sanitized

packages/core/src/shared/utilities/workspaceUtils.ts

@@ -693,7 +693,7 @@ export function formatListing(name: string, fileType: vscode.FileType, fullPath:
  * You can either pass a custom callback or rely on the default `formatListing`.
  *
  * @param dirUri The folder to begin traversing
- * @param maxDepth Maximum depth to descend (0 => just this folder, if it's missing -> recursively)
+ * @param maxDepth Maximum depth to descend (0 => just this folder, if it's missing => recursively)
  * @param customFormatCallback Optional. If given, it will override the default line-formatting
  */
 export async function readDirectoryRecursively(
@@ -702,8 +702,7 @@ export async function readDirectoryRecursively(
     customFormatCallback?: (name: string, fileType: vscode.FileType, fullPath: string) => string
 ): Promise<string[]> {
     const logger = getLogger()
-    maxDepth = maxDepth ?? -1
-    const depthDescription = maxDepth < 0 ? 'unlimited' : maxDepth
+    const depthDescription = maxDepth === undefined ? 'unlimited' : maxDepth
     logger.info(`Reading directory: ${dirUri.fsPath} to max depth: ${depthDescription}`)
 
     const queue: Array<{ uri: vscode.Uri; depth: number }> = [{ uri: dirUri, depth: 0 }]
@@ -713,7 +712,7 @@ export async function readDirectoryRecursively(
 
     while (queue.length > 0) {
         const { uri, depth } = queue.shift()!
-        if (maxDepth >= 0 && depth > maxDepth) {
+        if (maxDepth !== undefined && depth > maxDepth) {
             logger.info(`Skipping directory: ${uri.fsPath} (depth ${depth} > max ${maxDepth})`)
             continue
         }
@@ -731,7 +730,7 @@ export async function readDirectoryRecursively(
             const childUri = vscode.Uri.joinPath(uri, name)
             results.push(formatter(name, fileType, childUri.fsPath))
 
-            if (fileType === vscode.FileType.Directory && (maxDepth < 0 || depth < maxDepth)) {
+            if (fileType === vscode.FileType.Directory && (maxDepth === undefined || depth < maxDepth)) {
                 queue.push({ uri: childUri, depth: depth + 1 })
             }
         }

packages/core/src/test/codewhispererChat/tools/listDirectory.test.ts

@@ -19,6 +19,15 @@ describe('ListDirectory Tool', () => {
         await assert.rejects(listDirectory.validate(), /Path cannot be empty/i, 'Expected an error about empty path')
     })
 
+    it('throws if maxDepth is negative', async () => {
+        const listDirectory = new ListDirectory({ path: '~', maxDepth: -1 })
+        await assert.rejects(
+            listDirectory.validate(),
+            /MaxDepth cannot be negative/i,
+            'Expected an error about negative maxDepth'
+        )
+    })
+
     it('lists directory contents', async () => {
         await testFolder.mkdir('subfolder')
         await testFolder.write('fileA.txt', 'fileA content')