Skip to content

Commit cbf2daf

Browse files
authored
fix(cloudformation): allow empty string in parameter (#175)
Allow empty string to be passed in as parameters
1 parent 803bf04 commit cbf2daf

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

packages/core/src/awsService/cloudformation/stacks/actions/stackActionInputValidation.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ export function validateChangeSetName(value: string): string | undefined {
5757
}
5858

5959
export function validateParameterValue(input: string, param: TemplateParameter): string | undefined {
60-
if (!input && !param.Default) {
61-
return `Parameter ${param.name} is required`
62-
}
63-
6460
const actualValue = input ?? param.Default?.toString() ?? ''
6561

6662
// Handle CommaDelimitedList validation

packages/core/src/test/awsService/cloudformation/stacks/actions/stackActionInputValidation.test.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,15 @@ describe('validateParameterValue', function () {
6666
assert.strictEqual(validateParameterValue('2', param), undefined)
6767
assert.strictEqual(validateParameterValue('3', param), 'Value must be one of: 1, 2')
6868
})
69+
70+
it('should handle empty string values', function () {
71+
const param: TemplateParameter = {
72+
name: 'TestParam',
73+
Type: 'String',
74+
}
75+
76+
assert.strictEqual(validateParameterValue('', param), undefined)
77+
})
6978
})
7079

7180
describe('Number parameters', function () {

0 commit comments

Comments
 (0)