Switch to winston splat-style logging (printf-style) (#1108)

Author: ckant

package.json

@@ -104,13 +104,15 @@
                         "error",
                         "warn",
                         "info",
-                        "verbose"
+                        "verbose",
+                        "debug"
                     ],
                     "enumDescriptions": [
                         "Errors Only",
                         "Errors and Warnings",
                         "Errors, Warnings, and Info",
-                        "Errors, Warnings, Info, and Verbose"
+                        "Errors, Warnings, Info, and Verbose",
+                        "Errors, Warnings, Info, Verbose, and Debug"
                     ],
                     "markdownDescription": "%AWS.configuration.description.logLevel%"
                 },

src/awsexplorer/awsExplorer.ts

@@ -81,7 +81,7 @@ export class AwsExplorer implements vscode.TreeDataProvider<AWSTreeNodeBase>, Re
             }
         } catch (err) {
             const error = err as Error
-            this.logger.error(`Error getting children for node ${element?.label ?? 'Root Node'}`, error)
+            this.logger.error(`Error getting children for node ${element?.label ?? 'Root Node'}: %O`, error)
 
             childNodes.splice(
                 0,

src/cdk/explorer/detectCdkProjects.ts

@@ -72,6 +72,6 @@ async function* detectCdkProjectsInFolder(folder: string): AsyncIterableIterator
         yield vscode.Uri.file(cdkJsonPath)
     } catch (err) {
         // This is usually because the file doesn't exist, but could also be a permissions issue.
-        getLogger().debug(`Error detecting CDK apps in ${folder}`, err as Error)
+        getLogger().debug(`Error detecting CDK apps in ${folder}: %O`, err as Error)
     }
 }

src/cdk/explorer/nodes/appNode.ts

@@ -77,7 +77,7 @@ export class AppNode extends AWSTreeNodeBase {
 
             return constructs
         } catch (error) {
-            getLogger().error(`Could not load the construct tree located at '${this.id}'`, error as Error)
+            getLogger().error(`Could not load the construct tree located at '${this.id}': %O`, error as Error)
 
             return [
                 new PlaceholderNode(

src/credentials/loginManager.ts

@@ -61,7 +61,7 @@ export class LoginManager {
             getLogger().error(
                 `Error trying to connect to AWS with Credentials Provider ${asString(
                     credentialsProviderId
-                )}. Toolkit will now disconnect from AWS.`,
+                )}. Toolkit will now disconnect from AWS. %O`,
                 err as Error
             )
             this.credentialsStore.invalidateCredentials(credentialsProviderId)

src/eventSchemas/commands/downloadSchemaItemCode.ts

@@ -88,7 +88,7 @@ export async function downloadSchemaItemCode(node: SchemaItemNode, outputChannel
             errorMessage = error.message
         }
         vscode.window.showErrorMessage(errorMessage)
-        logger.error('Error downloading schema', error)
+        logger.error('Error downloading schema: %O', error)
     } finally {
         recordSchemasDownload({ result: downloadResult })
     }

src/eventSchemas/commands/searchSchemas.ts

@@ -93,7 +93,7 @@ export async function createSearchSchemasWebView(params: {
     } catch (err) {
         webviewResult = 'Failed'
         const error = err as Error
-        logger.error('Error searching schemas', error)
+        logger.error('Error searching schemas: %O', error)
     } finally {
         // TODO make this telemetry actually record failures
         recordSchemasSearch({ result: webviewResult })

src/eventSchemas/commands/viewSchemaItem.ts

@@ -29,7 +29,7 @@ export async function viewSchemaItem(node: SchemaItemNode) {
                 node.schemaName
             )
         )
-        logger.error('Error on schema preview', error)
+        logger.error('Error on schema preview: %O', error)
     } finally {
         recordSchemasView({ result: viewResult })
     }

src/eventSchemas/providers/schemasDataProvider.ts

@@ -55,7 +55,7 @@ export class SchemasDataProvider {
             }
         } catch (err) {
             const error = err as Error
-            this.logger.error('Error retrieving registries', error)
+            this.logger.error('Error retrieving registries: %O', error)
 
             return undefined
         }
@@ -86,7 +86,7 @@ export class SchemasDataProvider {
             }
         } catch (err) {
             const error = err as Error
-            this.logger.error('Error retrieving schemas', error)
+            this.logger.error('Error retrieving schemas: %O', error)
 
             return undefined
         }

src/extension.ts

@@ -249,7 +249,7 @@ function makeEndpointsProvider(): EndpointsProvider {
     const provider = new EndpointsProvider(localManifestFetcher, remoteManifestFetcher)
     // tslint:disable-next-line:no-floating-promises -- start the load without waiting. It raises events as fetchers retrieve data.
     provider.load().catch((err: Error) => {
-        getLogger().error('Failure while loading Endpoints Manifest', err)
+        getLogger().error('Failure while loading Endpoints Manifest: %O', err)
 
         vscode.window.showErrorMessage(
             localize(