Skip to content

Commit cedba14

Browse files
authored
cwl: telemetry #3618
1 parent a316bee commit cedba14

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

src/cloudWatchLogs/activation.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,12 @@ export async function activate(context: vscode.ExtensionContext, configuration:
8484
Commands.register('aws.cwl.viewLogStream', async (node: LogGroupNode) => await viewLogStream(node, registry)),
8585

8686
Commands.register('aws.cwl.searchLogGroup', async (node: LogGroupNode | CloudWatchLogsNode) => {
87-
let logGroupInfo = undefined
88-
89-
if (node instanceof LogGroupNode) {
90-
logGroupInfo = { regionName: node.regionCode, groupName: node.logGroup.logGroupName! }
91-
}
92-
93-
await searchLogGroup(registry, logGroupInfo)
87+
const logGroupInfo =
88+
node instanceof LogGroupNode
89+
? { regionName: node.regionCode, groupName: node.logGroup.logGroupName! }
90+
: undefined
91+
const source = node ? (logGroupInfo ? 'ExplorerLogGroupNode' : 'ExplorerServiceNode') : 'Command'
92+
await searchLogGroup(registry, source, logGroupInfo)
9493
}),
9594

9695
Commands.register('aws.cwl.changeFilterPattern', async () => changeLogSearchParams(registry, 'filterPattern')),

src/cloudWatchLogs/commands/searchLogGroup.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,21 @@ export async function prepareDocument(uri: vscode.Uri, logData: CloudWatchLogsDa
8383
}
8484
}
8585

86-
/** "Search Log Group" command */
86+
/**
87+
* "Search Log Group" command
88+
*
89+
* @param registry
90+
* @param source Telemetry "source" name
91+
* @param logData
92+
*/
8793
export async function searchLogGroup(
8894
registry: LogDataRegistry,
95+
source: string,
8996
logData?: { regionName: string; groupName: string }
9097
): Promise<void> {
9198
await telemetry.cloudwatchlogs_open.run(async span => {
9299
const wizard = new SearchLogGroupWizard(logData)
93-
span.record({ source: logData ? 'Explorer' : 'Command', cloudWatchResourceType: 'logGroup' })
100+
span.record({ cloudWatchResourceType: 'logGroup', source: source })
94101
const response = await wizard.run()
95102
if (!response) {
96103
throw new CancellationError('user')

src/cloudWatchLogs/commands/viewLogStream.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ export async function viewLogStream(node: LogGroupNode, registry: LogDataRegistr
3737
}
3838

3939
if (r.kind === 'doSearchLogGroup') {
40-
return searchLogGroup(registry, { regionName: node.regionCode, groupName: node.logGroup.logGroupName! })
40+
return searchLogGroup(registry, 'LogStreamMenu', {
41+
regionName: node.regionCode,
42+
groupName: node.logGroup.logGroupName!,
43+
})
4144
}
4245

4346
const logGroupInfo: CloudWatchLogsGroupInfo = {

0 commit comments

Comments
 (0)