merge in master

Author: Hweinstock

.github/workflows/jscpd.json

@@ -0,0 +1,7 @@
+{
+    "pattern": "packages/**/*.ts",
+    "ignore": ["**node_modules**", "**dist**"],
+    "gitignore": true,
+    "threshold": 1.34,
+    "minLines": 15
+}

.github/workflows/node.js.yml

@@ -41,7 +41,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [stable]
         env:
             NODE_OPTIONS: '--max-old-space-size=8192'
@@ -55,14 +55,32 @@ jobs:
             - run: npm run testCompile
             - run: npm run lint
 
+    jscpd:
+        needs: lint-commits
+        runs-on: ubuntu-latest
+        strategy:
+            matrix:
+                node-version: [18.x]
+        env:
+            NODE_OPTIONS: '--max-old-space-size=8192'
+        steps:
+            - uses: actions/checkout@v4
+            - name: Use Node.js ${{ matrix.node-version }}
+              uses: actions/setup-node@v4
+              with:
+                  node-version: ${{ matrix.node-version }}
+            - run: npm install jscpd
+            - name: Run jscpd
+              run: npx jscpd --config "$GITHUB_WORKSPACE/.github/workflows/jscpd.json"
+
     macos:
         needs: lint-commits
         name: test macOS
         runs-on: macos-latest
         strategy:
             fail-fast: false
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [minimum, stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
@@ -110,7 +128,7 @@ jobs:
         strategy:
             fail-fast: true
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
@@ -136,7 +154,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}

buildspec/linuxIntegrationTests.yml

@@ -21,7 +21,7 @@ phases:
     install:
         run-as: root
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
             dotnet: 6.0
             java: latest
 

buildspec/linuxTests.yml

@@ -18,7 +18,7 @@ phases:
     install:
         run-as: root
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
         commands:
             - bash buildspec/shared/linux-install.sh
 

buildspec/packageTestVsix.yml

@@ -13,7 +13,7 @@ phases:
     install:
         run-as: root
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
         commands:
             - bash buildspec/shared/linux-install.sh
 

buildspec/windowsTests.yml

@@ -5,7 +5,7 @@ env:
 phases:
     install:
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
         commands:
             - |
                 if(-Not($Env:CODECOV_TOKEN -eq $null)) {

docs/telemetry-perf.md

@@ -258,3 +258,70 @@ How long it took from when the user stopped pressing a key to when they were sho
         rHandler->>User: add to already shown results
         end
 ```
+
+## Crash Monitoring
+
+We make an attempt to gather information regarding when the IDE crashes, then report it to telemetry. This is the diagram of the steps that take place.
+
+### Sequence Diagram
+
+> Keep in mind that the entire sequence below is duplicated for each instance of our extension.
+> They all work together to "crash check" on behalf of the other crashed extension instance.
+
+`Crash Service`: The high level "service" that starts the heartbeats and crash checks
+
+`Heartbeat`: Sends heartbeats which signal that the extension is still running and has not crashed
+
+`Crash Checker`: Observes the heartbeats, reporting a telemetry event if a crash is detected
+
+`File System State`: The user's file system where we store the heartbeat files from each extension instance
+
+```mermaid
+%%{init: {'theme':'default'}}%%
+sequenceDiagram
+  autonumber
+
+  participant VSC as VS Code
+  participant Service as Crash Service
+  participant Checker as Crash Checker
+  participant Heartbeat as Heartbeat
+  participant State as File System State
+  participant Telemetry as Telemetry
+
+  rect rgb(121, 210, 121)
+    alt Extension Startup
+        VSC ->> Service: activate() - Start Service
+
+        Service ->> Heartbeat: Start Heartbeats
+        Heartbeat ->> State: Send Initial Heartbeat <br/> (in a folder add a unique file w/ timestamp)
+        rect rgb(64, 191, 64)
+            par every N minutes
+                Heartbeat ->> State: Send Heartbeat <br/> (overwrite the unique file w/ new timestamp)
+            end
+        end
+
+        Service ->> Checker: Start Crash Checking
+        rect rgb(64, 191, 64)
+            par every N*2 minutes
+                Checker ->> Checker: If computer went to sleep, skip this iteration (gives time for a heartbeat)
+                Checker ->> State: Request all heartbeat timestamps (readdir all heartbeat files)
+                State ->> Checker: Receive all heartbeat timestamps
+                loop for each crashed extension (it's timestamp >= N*2 minutes)
+                    Checker ->> State: Delete heartbeat file
+                    Checker ->> Telemetry: Send metric representing a crash: session_end
+                end
+            end
+        end
+    end
+  end
+
+  rect rgb(255, 128, 128)
+    alt Graceful Shutdown
+        VSC ->> Service: deactivate() - Stop Service
+        Service ->> Checker: Stop
+        Service ->> Heartbeat: Stop
+        Heartbeat ->> State: Delete timestamp file <br/> (This is missed when a crash happens)
+    end
+  end
+
+```