refactor(watchedfiles): rename getRegisteredItem => getItem

Problem:
getRegisteredItem implies there is some other kind of "item", which is
confusing.

Solution:
Rename to getItem.

Author: justinmk3

src/codecatalyst/devfile.ts

@@ -66,7 +66,7 @@ export class DevfileCodeLensProvider implements vscode.CodeLensProvider {
         this.disposables.push(this._onDidChangeCodeLenses)
         this.disposables.push(
             workspace.onDidSaveTextDocument(async document => {
-                if (!registry.getRegisteredItem(document.fileName)) {
+                if (!registry.getItem(document.fileName)) {
                     return
                 }
 

src/lambda/commands/createNewSamApp.ts

@@ -271,7 +271,7 @@ export async function createNewSamApplication(
         // Race condition where SAM app is created but template doesn't register in time.
         // Poll for 5 seconds, otherwise direct user to codelens.
         const isTemplateRegistered = await waitUntil(
-            async () => (await globals.templateRegistry).getRegisteredItem(templateUri),
+            async () => (await globals.templateRegistry).getItem(templateUri),
             {
                 timeout: 5000,
                 interval: 500,

src/lambda/local/debugConfiguration.ts

@@ -193,7 +193,7 @@ export async function getTemplate(
     }
     const templateInvoke = config.invokeTarget as TemplateTargetProperties
     const fullPath = tryGetAbsolutePath(folder, templateInvoke.templatePath)
-    const cfnTemplate = (await globals.templateRegistry).getRegisteredItem(fullPath)?.item
+    const cfnTemplate = (await globals.templateRegistry).getItem(fullPath)?.item
     return cfnTemplate
 }
 

src/lambda/wizards/samDeployWizard.ts

@@ -211,7 +211,7 @@ export class DefaultSamDeployWizardContext implements SamDeployWizardContext {
     }
 
     public async determineIfTemplateHasImages(templatePath: vscode.Uri): Promise<boolean> {
-        const template = (await globals.templateRegistry).getRegisteredItem(templatePath.fsPath)
+        const template = (await globals.templateRegistry).getItem(templatePath.fsPath)
         const resources = template?.item?.Resources
         if (resources === undefined) {
             return false

src/shared/extensionGlobals.ts

@@ -109,6 +109,7 @@ interface ToolkitGlobals {
     regionProvider: RegionProvider
     sdkClientBuilder: AWSClientBuilder
     telemetry: TelemetryService & { logger: TelemetryLogger }
+    /** template.yaml registry. _Avoid_ calling this until it is actually needed (for SAM features). */
     templateRegistry: Promise<CloudFormationTemplateRegistry>
     schemaService: SchemaService
     codelensRootRegistry: CodelensRootRegistry

src/shared/fs/watchedFiles.ts

@@ -200,12 +200,13 @@ export abstract class WatchedFiles<T> implements vscode.Disposable {
     }
 
     /**
-     * Get a specific item's data
-     * Untitled files must be referred to by their URI
+     * Gets an item by filepath or URI.
+     *
+     * Untitled files must be referred to by URI.
+     *
      * @param path Absolute path to item of interest or a vscode.Uri to the item
      */
-    public getRegisteredItem(path: string | vscode.Uri): WatchedItem<T> | undefined {
-        // fsPath is needed for Windows, it's equivalent to path on mac/linux
+    public getItem(path: string | vscode.Uri): WatchedItem<T> | undefined {
         const normalizedPath = typeof path === 'string' ? pathutils.normalize(path) : normalizeVSCodeUri(path)
         this.assertAbsolute(normalizedPath)
         const item = this.registryData.get(normalizedPath)
@@ -225,7 +226,7 @@ export abstract class WatchedFiles<T> implements vscode.Disposable {
         const arr: WatchedItem<T>[] = []
 
         for (const itemPath of this.registryData.keys()) {
-            const item = this.getRegisteredItem(itemPath)
+            const item = this.getItem(itemPath)
             if (item) {
                 arr.push(item)
             }

src/shared/sam/debugger/awsSamDebugConfigurationValidator.ts

@@ -72,7 +72,7 @@ export class DefaultAwsSamDebugConfigurationValidator implements AwsSamDebugConf
                 const fullpath = tryGetAbsolutePath(this.workspaceFolder, config.invokeTarget.templatePath)
                 // Normalize to absolute path for use in the runner.
                 config.invokeTarget.templatePath = fullpath
-                cfnTemplate = registry.getRegisteredItem(fullpath)?.item
+                cfnTemplate = registry.getItem(fullpath)?.item
             }
             rv = this.validateTemplateConfig(config, config.invokeTarget.templatePath, cfnTemplate)
         } else if (config.invokeTarget.target === CODE_TARGET_TYPE) {

src/shared/sam/debugger/commands/addSamDebugConfiguration.ts

@@ -57,7 +57,7 @@ export async function addSamDebugConfiguration(
         let preloadedConfig = undefined
 
         if (workspaceFolder) {
-            const templateDatum = (await globals.templateRegistry).getRegisteredItem(rootUri)
+            const templateDatum = (await globals.templateRegistry).getItem(rootUri)
             if (templateDatum) {
                 const resource = templateDatum.item.Resources![resourceName]
                 if (!resource) {

src/test/shared/fs/templateRegistry.test.ts

@@ -44,7 +44,7 @@ describe('CloudFormation Template Registry', async function () {
 
                 assert.strictEqual(testRegistry.registeredItems.length, 1)
 
-                const data = testRegistry.getRegisteredItem(filename.fsPath)
+                const data = testRegistry.getItem(filename.fsPath)
 
                 assertValidTestTemplate(data, filename.fsPath)
             })
@@ -71,21 +71,21 @@ describe('CloudFormation Template Registry', async function () {
                 await strToYamlFile(goodYaml1, filename.fsPath)
                 await testRegistry.addItemToRegistry(filename)
 
-                const data = testRegistry.getRegisteredItem(filename)
+                const data = testRegistry.getItem(filename)
 
                 assertValidTestTemplate(data, filename.fsPath)
             })
 
             it('returns undefined if the registry has no registered templates', function () {
-                assert.strictEqual(testRegistry.getRegisteredItem('/template.yaml'), undefined)
+                assert.strictEqual(testRegistry.getItem('/template.yaml'), undefined)
             })
 
             it('returns undefined if the registry does not contain the template in question', async function () {
                 const filename = vscode.Uri.file(path.join(tempFolder, 'template.yaml'))
                 await strToYamlFile(goodYaml1, filename.fsPath)
                 await testRegistry.addItemToRegistry(vscode.Uri.file(filename.fsPath))
 
-                assert.strictEqual(testRegistry.getRegisteredItem('/not-the-template.yaml'), undefined)
+                assert.strictEqual(testRegistry.getItem('/not-the-template.yaml'), undefined)
             })
         })
 

src/test/shared/sam/debugger/awsSamDebugConfigurationValidator.test.ts

@@ -104,8 +104,8 @@ describe('DefaultAwsSamDebugConfigurationValidator', function () {
     let validator: DefaultAwsSamDebugConfigurationValidator
 
     beforeEach(function () {
-        when(mockRegistry.getRegisteredItem('/')).thenReturn(templateData)
-        when(mockRegistry.getRegisteredItem('/image')).thenReturn(imageTemplateData)
+        when(mockRegistry.getItem('/')).thenReturn(templateData)
+        when(mockRegistry.getItem('/image')).thenReturn(imageTemplateData)
 
         validator = new DefaultAwsSamDebugConfigurationValidator(instance(mockFolder))
     })
@@ -126,7 +126,7 @@ describe('DefaultAwsSamDebugConfigurationValidator', function () {
 
     it("returns invalid when resolving template debug configurations with a template that isn't in the registry", () => {
         const mockEmptyRegistry: CloudFormationTemplateRegistry = mock()
-        when(mockEmptyRegistry.getRegisteredItem('/')).thenReturn(undefined)
+        when(mockEmptyRegistry.getItem('/')).thenReturn(undefined)
 
         validator = new DefaultAwsSamDebugConfigurationValidator(instance(mockFolder))