cleaner solution to cancel problem

Hweinstock · Hweinstock · commit d154a23d5671 · 2023-08-08T08:20:04.000-07:00
diff --git a/src/shared/remoteSession.ts b/src/shared/remoteSession.ts
@@ -213,8 +213,8 @@ async function addInlinePolicyWithDelay(client: IamClient, roleArn: string) {
         return new Promise(resolve => setTimeout(resolve, ms))
     }
 
-    await delay(policyAttachDelay - 100)
-    if (timeout.completed) {
+    await delay(policyAttachDelay)
+    if (timeout.elapsedTime < policyAttachDelay) {
         throw new CancellationError('user')
     }
     timeout.cancel()

Original file line number	Diff line number	Diff line change
`@@ -213,8 +213,8 @@ async function addInlinePolicyWithDelay(client: IamClient, roleArn: string) {`
`213`	`213`	`return new Promise(resolve => setTimeout(resolve, ms))`
`214`	`214`	`}`
`215`	`215`
`216`		`- await delay(policyAttachDelay - 100)`
`217`		`- if (timeout.completed) {`
	`216`	`+ await delay(policyAttachDelay)`
	`217`	`+ if (timeout.elapsedTime < policyAttachDelay) {`
`218`	`218`	`throw new CancellationError('user')`
`219`	`219`	`}`
`220`	`220`	`timeout.cancel()`