pass in the negative version of --use-container when using build quickpick

Author: mbfreder

packages/core/src/shared/sam/build.ts

@@ -29,6 +29,7 @@ import {
 } from './utils'
 import { getConfigFileUri, validateSamBuildConfig } from './config'
 import { runInTerminal } from './processTerminal'
+import { getLogger } from '../logger'
 
 const buildMementoRootKey = 'samcli.build.params'
 export interface BuildParams {
@@ -213,7 +214,7 @@ export async function runBuild(arg?: TreeNode): Promise<SamBuildResult> {
     // refactor
     const buildFlags: string[] =
         params.paramsSource === ParamsSource.Specify && params.buildFlags
-            ? JSON.parse(params.buildFlags)
+            ? resolveBuildFlags(JSON.parse(params.buildFlags))
             : await getBuildFlags(params.paramsSource, projectRoot, defaultFlags)
 
     // todo remove
@@ -281,3 +282,9 @@ function resolveBuildArgConflict(boundArgs: string[]): string[] {
     // }
     return Array.from(boundArgsSet)
 }
+export function resolveBuildFlags(buildFlags: string[]): string[] {
+    if (!buildFlags.includes('--use-container')) {
+        buildFlags.push('--no-use-container')
+    }
+    return buildFlags
+}

packages/core/src/test/shared/sam/build.test.ts

@@ -16,6 +16,7 @@ import {
     createParamsSourcePrompter,
     getBuildFlags,
     ParamsSource,
+    resolveBuildFlags,
     runBuild,
 } from '../../../shared/sam/build'
 import { TreeNode } from '../../../shared/treeview/resourceTreeDataProvider'
@@ -229,6 +230,14 @@ describe('SAM build helper functions', () => {
             assert.deepStrictEqual(quickPick.items, expectedItems)
         })
     })
+
+    describe('resolveBuildFlags', () => {
+        it('should add --no-use-container if the buildFlags array does not contain --use-container', () => {
+            const buildFlags: string[] = ['--cached', '--debug', '--parallel']
+            const resolvedBuildFlags = ['--cached', '--debug', '--parallel', '--no-use-container']
+            assert.deepStrictEqual(resolvedBuildFlags, resolveBuildFlags(buildFlags))
+        })
+    })
 })
 
 describe('SAM runBuild', () => {