Skip to content

Commit d18794e

Browse files
author
David Hasani
committed
address comment
1 parent 001f488 commit d18794e

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,6 @@ export class ProposedTransformationExplorer {
408408
const metricsPath = path.join(pathContainingArchive, ExportResultArchiveStructure.PathToMetrics)
409409
const metricsData = JSON.parse(fs.readFileSync(metricsPath, 'utf8'))
410410

411-
// TO-DO: add support for SQL conversions; right now these metrics are only available for Java upgrades
412411
await codeWhisperer.codeWhispererClient.sendTelemetryEvent({
413412
telemetryEvent: {
414413
transformEvent: {
@@ -423,7 +422,7 @@ export class ProposedTransformationExplorer {
423422
},
424423
linesOfCodeChanged: metricsData.linesOfCodeChanged,
425424
charsOfCodeChanged: metricsData.charactersOfCodeChanged,
426-
linesOfCodeSubmitted: transformByQState.getLinesOfCodeSubmitted(),
425+
linesOfCodeSubmitted: transformByQState.getLinesOfCodeSubmitted(), // currently unavailable for SQL conversions
427426
},
428427
},
429428
})

packages/core/src/shared/utilities/download.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
import path from 'path'
76
import { CodeWhispererStreaming, ExportResultArchiveCommandInput } from '@amzn/codewhisperer-streaming'
87
import { ToolkitError } from '../errors'
98
import fs from '../fs/fs'
@@ -12,9 +11,9 @@ import fs from '../fs/fs'
1211
* This class represents the structure of the archive returned by the ExportResultArchive endpoint
1312
*/
1413
export class ExportResultArchiveStructure {
15-
static readonly PathToSummary = path.join('summary', 'summary.md')
16-
static readonly PathToDiffPatch = path.join('patch', 'diff.patch')
17-
static readonly PathToMetrics = path.join('metrics', 'metrics.json')
14+
static readonly PathToSummary = 'summary/summary.md'
15+
static readonly PathToDiffPatch = 'patch/diff.patch'
16+
static readonly PathToMetrics = 'metrics/metrics.json'
1817
static readonly PathToManifest = 'manifest.json'
1918
}
2019

0 commit comments

Comments
 (0)