fix: use cache dirs from dirs create

Author: jpinkney-aws

packages/core/src/shared/languageServer/lspResolver.ts

@@ -10,7 +10,7 @@ import * as path from 'path'
 import { FileType } from 'vscode'
 import AdmZip from 'adm-zip'
 import { TargetContent, logger, LspResult, LspVersion, Manifest } from './types'
-import { getApplicationSupportFolder } from '../vscode/env'
+import { getApplicationCacheFolder } from '../vscode/env'
 import { createHash } from '../crypto'
 import request from '../request'
 
@@ -341,8 +341,8 @@ export class LanguageServerResolver {
     }
 
     private defaultDownloadFolder() {
-        const applicationSupportFolder = getApplicationSupportFolder()
-        return path.join(applicationSupportFolder, `aws/toolkits/language-servers/${this.lsName}`)
+        const applicationCacheFolder = getApplicationCacheFolder()
+        return path.join(applicationCacheFolder, `aws/toolkits/language-servers/${this.lsName}`)
     }
 
     getDownloadDirectory(version: string) {

packages/core/src/shared/vscode/env.ts

@@ -13,6 +13,8 @@ import { ChildProcess } from '../utilities/processUtils'
 import globals, { isWeb } from '../extensionGlobals'
 import * as devConfig from '../../dev/config'
 import path from 'path'
+import { fs } from '../fs/fs'
+import { ToolkitError } from '../errors'
 
 /**
  * Returns true if the current build is running on CI (build server).
@@ -272,16 +274,28 @@ export async function getMachineId(): Promise<string> {
     return (await proc.run()).stdout.trim() ?? 'unknown-host'
 }
 
-export function getApplicationSupportFolder() {
+/**
+ * Gets the application cache folder for the current platform
+ *
+ * Follows the cache_dir convention outlined in https://crates.io/crates/dirs
+ */
+export function getApplicationCacheFolder() {
+    const homeDir = fs.getUserHomeDir()
     switch (process.platform) {
         case 'darwin': {
-            return path.join(os.homedir(), 'Library/Application Support')
+            return path.join(homeDir, 'Library/Caches')
         }
         case 'win32': {
-            return process.env.APPDATA
+            const localAppData = process.env.LOCALAPPDATA
+            if (!localAppData) {
+                throw new ToolkitError('LOCALAPPDATA environment variable not set', {
+                    code: 'LocalAppDataNotFound',
+                })
+            }
+            return localAppData
         }
         case 'linux': {
-            return process.env.XDG_CACHE_HOME || path.join(os.homedir(), '.cache')
+            return path.join(homeDir, '.cache')
         }
         default: {
             throw new Error(`Unsupported platform: ${process.platform}. Expected 'darwin', 'win32', or 'linux'.`)