lint: enable noImplicitOverride in tsc (#3143)

## Problem
It's not always obvious that classes are overriding methods in a base class

## Solution
Enforce usage of the override keyword

Author: JadenSimon

src/apigateway/explorer/apiGatewayNodes.ts

@@ -24,14 +24,14 @@ export class ApiGatewayNode extends AWSTreeNodeBase {
 
     public constructor(
         private readonly partitionId: string,
-        public readonly regionCode: string,
+        public override readonly regionCode: string,
         private readonly client = new DefaultApiGatewayClient(regionCode)
     ) {
         super('API Gateway', vscode.TreeItemCollapsibleState.Collapsed)
         this.apiNodes = new Map<string, RestApiNode>()
     }
 
-    public async getChildren(): Promise<AWSTreeNodeBase[]> {
+    public override async getChildren(): Promise<AWSTreeNodeBase[]> {
         return await makeChildrenNodes({
             getChildNodes: async () => {
                 await this.updateChildren()

src/apigateway/explorer/apiNodes.ts

@@ -8,12 +8,12 @@ import { AWSTreeNodeBase } from '../../shared/treeview/nodes/awsTreeNodeBase'
 import { RestApi } from 'aws-sdk/clients/apigateway'
 
 export class RestApiNode extends AWSTreeNodeBase implements AWSResourceNode {
-    public id!: string
+    public override id!: string
 
     public constructor(
         public readonly parent: AWSTreeNodeBase,
         public readonly partitionId: string,
-        public readonly regionCode: string,
+        public override readonly regionCode: string,
         private api: RestApi
     ) {
         super('')

src/apprunner/explorer/apprunnerNode.ts

@@ -21,12 +21,12 @@ export class AppRunnerNode extends AWSTreeNodeBase {
     private readonly pollingNodes: Set<string> = new Set()
     private pollTimer?: NodeJS.Timeout
 
-    public constructor(public readonly regionCode: string, public readonly client: AppRunnerClient) {
+    public constructor(public override readonly regionCode: string, public readonly client: AppRunnerClient) {
         super('App Runner', vscode.TreeItemCollapsibleState.Collapsed)
         this.contextValue = 'awsAppRunnerNode'
     }
 
-    public async getChildren(): Promise<AWSTreeNodeBase[]> {
+    public override async getChildren(): Promise<AWSTreeNodeBase[]> {
         return await makeChildrenNodes({
             getChildNodes: async () => {
                 await this.updateChildren()

src/awsexplorer/regionNode.ts

@@ -85,7 +85,7 @@ const serviceCandidates = [
  */
 export class RegionNode extends AWSTreeNodeBase {
     private region: Region
-    public readonly regionCode: string
+    public override readonly regionCode: string
 
     public get regionName(): string {
         return this.region.name
@@ -99,7 +99,7 @@ export class RegionNode extends AWSTreeNodeBase {
         this.update(region)
     }
 
-    public async getChildren(): Promise<AWSTreeNodeBase[]> {
+    public override async getChildren(): Promise<AWSTreeNodeBase[]> {
         //  Services that are candidates to add to the region explorer.
         //  `serviceId`s are checked against ~/resources/endpoints.json to see whether or not the service is available in the given region.
         //  If the service is available, we use the `createFn` to generate the node for the region.

src/cloudWatchLogs/explorer/cloudWatchLogsNode.ts

@@ -23,7 +23,7 @@ export abstract class CloudWatchLogsBase extends AWSTreeNodeBase {
 
     public constructor(
         label: string,
-        public readonly regionCode: string,
+        public override readonly regionCode: string,
         protected readonly cloudwatchClient: DefaultCloudWatchLogsClient
     ) {
         super(label, vscode.TreeItemCollapsibleState.Collapsed)
@@ -32,7 +32,7 @@ export abstract class CloudWatchLogsBase extends AWSTreeNodeBase {
 
     protected abstract getLogGroups(): Promise<Map<string, CloudWatchLogs.LogGroup>>
 
-    public async getChildren(): Promise<AWSTreeNodeBase[]> {
+    public override async getChildren(): Promise<AWSTreeNodeBase[]> {
         return await makeChildrenNodes({
             getChildNodes: async () => {
                 await this.updateChildren()

src/cloudWatchLogs/explorer/logGroupNode.ts

@@ -13,7 +13,7 @@ import { localize } from '../../shared/utilities/vsCodeUtils'
 export const contextValueCloudwatchLog = 'awsCloudWatchLogNode'
 
 export class LogGroupNode extends AWSTreeNodeBase implements AWSResourceNode {
-    public constructor(public readonly regionCode: string, public logGroup: CloudWatchLogs.LogGroup) {
+    public constructor(public override readonly regionCode: string, public logGroup: CloudWatchLogs.LogGroup) {
         super('')
         this.update(logGroup)
         this.iconPath = getIcon('aws-cloudwatch-log-group')

src/credentials/providers/sharedCredentialsProviderFactory.ts

@@ -27,11 +27,11 @@ export class SharedCredentialsProviderFactory extends BaseCredentialsProviderFac
         }
     }
 
-    public getProviderType(): CredentialsProviderType | undefined {
+    public override getProviderType(): CredentialsProviderType | undefined {
         return SharedCredentialsProvider.getProviderType()
     }
 
-    protected resetProviders() {
+    protected override resetProviders() {
         this.loadedCredentialsModificationMillis = undefined
         this.loadedConfigModificationMillis = undefined
 

src/dynamicResources/explorer/nodes/resourceNode.ts

@@ -15,7 +15,7 @@ export class ResourceNode extends AWSTreeNodeBase {
     public constructor(
         public readonly parent: ResourceTypeNode,
         public readonly identifier: string,
-        public contextValue?: string
+        public override contextValue?: string
     ) {
         super('')
         this.contextValue = contextValue ?? 'ResourceNode'

src/dynamicResources/explorer/nodes/resourceTypeNode.ts

@@ -60,7 +60,7 @@ export class ResourceTypeNode extends AWSTreeNodeBase implements LoadMoreNode {
         this.childContextValue = supportedOperations.join('') + contextValueResource
     }
 
-    public async getChildren(): Promise<AWSTreeNodeBase[]> {
+    public override async getChildren(): Promise<AWSTreeNodeBase[]> {
         if (!this.metadata.available) {
             return []
         }

src/dynamicResources/explorer/nodes/resourcesNode.ts

@@ -33,7 +33,7 @@ export class ResourcesNode extends AWSTreeNodeBase {
         this.contextValue = 'resourcesRootNode'
     }
 
-    public async getChildren(): Promise<AWSTreeNodeBase[]> {
+    public override async getChildren(): Promise<AWSTreeNodeBase[]> {
         return await makeChildrenNodes({
             getChildNodes: async () => {
                 await this.updateChildren()