Skip to content

Commit d40b632

Browse files
fix(amazonq): put agentic review redirect behind feature flag
1 parent f2699b1 commit d40b632

File tree

4 files changed

+22
-10
lines changed

4 files changed

+22
-10
lines changed

packages/amazonq/src/app/amazonqScan/app.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { Messenger } from './chat/controller/messenger/messenger'
1919
import { UIMessageListener } from './chat/views/actions/uiMessageListener'
2020
import { debounce } from 'lodash'
2121
import { Commands, placeholder } from 'aws-core-vscode/shared'
22+
import { codeReviewInChat } from './models/constants'
2223

2324
export function init(appContext: AmazonQAppInitContext) {
2425
const scanChatControllerEventEmitters: ScanChatControllerEventEmitters = {
@@ -74,17 +75,19 @@ export function init(appContext: AmazonQAppInitContext) {
7475
return debouncedEvent()
7576
})
7677

77-
Commands.register('aws.amazonq.security.scan-statusbar', async () => {
78-
if (AuthUtil.instance.isConnectionExpired()) {
79-
await AuthUtil.instance.notifyReauthenticate()
80-
}
81-
return focusAmazonQPanel.execute(placeholder, 'amazonq.security.scan').then(() => {
82-
DefaultAmazonQAppInitContext.instance.getAppsToWebViewMessagePublisher().publish({
83-
sender: 'amazonqCore',
84-
command: 'review',
78+
if (!codeReviewInChat) {
79+
Commands.register('aws.amazonq.security.scan-statusbar', async () => {
80+
if (AuthUtil.instance.isConnectionExpired()) {
81+
await AuthUtil.instance.notifyReauthenticate()
82+
}
83+
return focusAmazonQPanel.execute(placeholder, 'amazonq.security.scan').then(() => {
84+
DefaultAmazonQAppInitContext.instance.getAppsToWebViewMessagePublisher().publish({
85+
sender: 'amazonqCore',
86+
command: 'review',
87+
})
8588
})
8689
})
87-
})
90+
}
8891

8992
codeScanState.setChatControllers(scanChatControllerEventEmitters)
9093
onDemandFileScanState.setChatControllers(scanChatControllerEventEmitters)

packages/amazonq/src/app/amazonqScan/models/constants.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,3 +97,5 @@ const getIconForStep = (targetStep: number, currentStep: number) => {
9797
? checkIcons.done
9898
: checkIcons.wait
9999
}
100+
101+
export const codeReviewInChat = false

packages/amazonq/src/lsp/chat/commands.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { CodeScanIssue } from 'aws-core-vscode/codewhisperer'
1010
import { getLogger } from 'aws-core-vscode/shared'
1111
import * as vscode from 'vscode'
1212
import * as path from 'path'
13+
import { codeReviewInChat } from '../../app/amazonqScan/models/constants'
1314

1415
/**
1516
* TODO: Re-enable these once we can figure out which path they're going to live in
@@ -61,6 +62,11 @@ export function registerCommands(provider: AmazonQChatViewProvider) {
6162
})
6263
})
6364
)
65+
if (codeReviewInChat) {
66+
globals.context.subscriptions.push(
67+
registerGenericCommand('aws.amazonq.security.scan-statusbar', 'Review', provider)
68+
)
69+
}
6470
}
6571

6672
async function handleIssueCommand(

packages/amazonq/src/lsp/client.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ import { SessionManager } from '../app/inline/sessionManager'
5050
import { LineTracker } from '../app/inline/stateTracker/lineTracker'
5151
import { InlineTutorialAnnotation } from '../app/inline/tutorials/inlineTutorialAnnotation'
5252
import { InlineChatTutorialAnnotation } from '../app/inline/tutorials/inlineChatTutorialAnnotation'
53+
import { codeReviewInChat } from '../app/amazonqScan/models/constants'
5354

5455
const localize = nls.loadMessageBundle()
5556
const logger = getLogger('amazonqLsp.lspClient')
@@ -168,7 +169,7 @@ export async function startLanguageServer(
168169
reroute: true,
169170
modelSelection: true,
170171
workspaceFilePath: vscode.workspace.workspaceFile?.fsPath,
171-
codeReviewInChat: false,
172+
codeReviewInChat,
172173
},
173174
window: {
174175
notifications: true,

0 commit comments

Comments
 (0)