fix(amazonq): update keybinding for focus chat #5910

grant0417 · web-flow · commit d4d1ae0d065e · 2024-11-07T15:06:00.000-08:00
Update the keybindings for Amazon Q's focus chat keybind to
win+alt+i on Windows, cmd+alt+i on macOS, and meta+alt+i on Linux. This
was requested by product to keep it consistent with the other keybinds.
diff --git a/packages/amazonq/.changes/next-release/Breaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json b/packages/amazonq/.changes/next-release/Breaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json
@@ -0,0 +1,4 @@
+{
+	"type": "Breaking Change",
+	"description": "Change focus chat keybind to win+alt+i on Windows, cmd+alt+i on macOS, and meta+alt+i on Linux"
+}
diff --git a/packages/amazonq/package.json b/packages/amazonq/package.json
@@ -609,9 +609,9 @@
         "keybindings": [
             {
                 "command": "_aws.amazonq.focusChat.keybinding",
-                "win": "ctrl+win+i",
-                "mac": "ctrl+cmd+i",
-                "linux": "ctrl+meta+i"
+                "win": "win+alt+i",
+                "mac": "cmd+alt+i",
+                "linux": "meta+alt+i"
             },
             {
                 "command": "aws.amazonq.explainCode",
diff --git a/packages/amazonq/src/inlineChat/controller/inlineChatController.ts b/packages/amazonq/src/inlineChat/controller/inlineChatController.ts
@@ -286,6 +286,7 @@ export class InlineChatController {
                     }
                 }
                 if (chatEvent.error) {
+                    getLogger().error('generateAssistantResponse stream error: %s', chatEvent.error)
                     await this.rejectAllChanges(this.task, false)
                     void vscode.window.showErrorMessage(`Amazon Q: ${chatEvent.error.message}`)
                     await this.updateTaskAndLenses(this.task, TaskState.Complete)

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +	"type": "Breaking Change",
 +	"description": "Change focus chat keybind to win+alt+i on Windows, cmd+alt+i on macOS, and meta+alt+i on Linux"
 +}
Original file line number	Diff line number	Diff line change
`@@ -609,9 +609,9 @@`
`609`	`609`	`"keybindings": [`
`610`	`610`	`{`
`611`	`611`	`"command": "_aws.amazonq.focusChat.keybinding",`
`612`		`- "win": "ctrl+win+i",`
`613`		`- "mac": "ctrl+cmd+i",`
`614`		`- "linux": "ctrl+meta+i"`
	`612`	`+ "win": "win+alt+i",`
	`613`	`+ "mac": "cmd+alt+i",`
	`614`	`+ "linux": "meta+alt+i"`
`615`	`615`	`},`
`616`	`616`	`{`
`617`	`617`	`"command": "aws.amazonq.explainCode",`
Original file line number	Diff line number	Diff line change
`@@ -286,6 +286,7 @@ export class InlineChatController {`
`286`	`286`	`}`
`287`	`287`	`}`
`288`	`288`	`if (chatEvent.error) {`
	`289`	`+ getLogger().error('generateAssistantResponse stream error: %s', chatEvent.error)`
`289`	`290`	`await this.rejectAllChanges(this.task, false)`
`290`	`291`	void vscode.window.showErrorMessage(`Amazon Q: ${chatEvent.error.message}`)
`291`	`292`	`await this.updateTaskAndLenses(this.task, TaskState.Complete)`