Skip to content

Commit d7bbf39

Browse files
authored
test: flaky walkthrough test (#8236)
## Problem The test is checking for a popup to confirm overwrite of the SAM template. It is most likely getting blocked due to the "Scanning cloudformation template" warning popup that shows up before. ## Solution #3510 says disabling AWS SAM Codelens removes the aforementioned popup so I added a statement to disable the statement beforehand, and enabled it after this test runs so as not to impact other tests. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent c34439a commit d7bbf39

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

packages/core/src/test/awsService/appBuilder/walkthrough.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,12 +223,15 @@ describe('AppBuilder Walkthrough', function () {
223223
assert.notEqual(await fs.readFileText(vscode.Uri.joinPath(workspaceUri, 'template.yaml')), prevInfo)
224224
})
225225

226-
it.skip('download serverlessland proj', async function () {
226+
it('download serverlessland proj', async function () {
227+
const config = vscode.workspace.getConfiguration('aws.samcli')
228+
await config.update('enableCodeLenses', false, vscode.ConfigurationTarget.Global)
227229
// When
228230
await genWalkthroughProject('API', workspaceUri, 'python')
229231
// Then template should be overwritten
230232
assert.equal(await fs.exists(vscode.Uri.joinPath(workspaceUri, 'template.yaml')), true)
231233
assert.notEqual(await fs.readFileText(vscode.Uri.joinPath(workspaceUri, 'template.yaml')), prevInfo)
234+
await config.update('enableCodeLenses', true, vscode.ConfigurationTarget.Global)
232235
})
233236
})
234237

0 commit comments

Comments
 (0)