fix race condition

Setting .html starts the loading of the UI, but setup() sets up the message listeners in the backend
for messages from the UI.

We had setup() come after, and it worked, but if I added a small sleep() before setup() was run
it would result in a failure due to messages not being handled due to handlers not being setup in time.

As a solution this just moves the handler setup before we set the new UI.

Signed-off-by: nkomonen-amazon <[email protected]>

Author: nkomonen-amazon

packages/core/src/login/webview/commonAuthViewProvider.ts

@@ -135,9 +135,10 @@ export class CommonAuthViewProvider implements WebviewViewProvider {
             enableCommandUris: true,
             localResourceRoots: [dist, resources],
         }
-        webviewView.webview.html = this._getHtmlForWebview(this.extensionContext.extensionUri, webviewView.webview)
         // register the webview server
         await this.webView?.setup(webviewView.webview)
+
+        webviewView.webview.html = this._getHtmlForWebview(this.extensionContext.extensionUri, webviewView.webview)
     }
 
     private _getHtmlForWebview(extensionURI: Uri, webview: vscode.Webview) {

packages/core/src/login/webview/vue/root.vue

@@ -85,7 +85,8 @@ export default defineComponent({
 // TODO: Move this in to a reusable class for other webviews, it feels a bit messy here
 let didSetReady = false
 
-// Setup error handlers to report 
+// Setup error handlers to report. This may not actually be able to catch certain errors that we'd expect,
+// so this may have to be revisited.
 window.onerror = function (message) {
     if (didSetReady) {
         return
@@ -119,7 +120,7 @@ const handleLoaded = () => {
     if (!foundElement) {
         setUiReady((window as any).uiState, `Could not find element: ${(window as any).uiReadyElementId}`)
     } else {
-        // Successful load!    
+        // Successful load!
         setUiReady((window as any).uiState)
     }
 }