fix(codecatalyst): disable New Branch for third-party repo #3258

Problem:
When creating a new Dev Env, the option to create a new branch name is
shown, but it can't work because CodeCatalyst doesn't support it.

Solution:
When a third-party repo is selected, disable the New Branch input.

Fixes IDE-10216

Signed-off-by: Nikolas Komonen <[email protected]>

Author: nkomonen-amazon

.changes/next-release/Bug Fix-c6fcd706-c5dc-4041-9fac-9260bd9994dd.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "CodeCatalyst: Disable new branch option when creating new Dev Environment for linked repo"
+}

.changes/next-release/Bug Fix-cd02d5c6-a80d-4e99-a1c9-16699843db88.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "CodeCatalyst: `Clone CodeCatalyst Repository` command now only lists non-linked repos"
+}

src/codecatalyst/vue/create/backend.ts

@@ -26,6 +26,7 @@ import {
     CodeCatalystProject,
     CodeCatalystClient,
     DevEnvironment,
+    isThirdPartyRepo,
 } from '../../../shared/clients/codecatalystClient'
 import { CancellationError } from '../../../shared/utilities/timeoutUtils'
 import { isCloud9 } from '../../../shared/extensionUtilities'
@@ -34,6 +35,7 @@ import { isNonNullable } from '../../../shared/utilities/tsUtils'
 import { recordSource } from '../../utils'
 import { QuickPickPrompter } from '../../../shared/ui/pickerPrompter'
 import { createProjectPrompter } from '../../wizards/selectResource'
+import { GetSourceRepositoryCloneUrlsRequest } from 'aws-sdk/clients/codecatalyst'
 
 interface LinkedResponse {
     readonly type: 'linked'
@@ -122,6 +124,10 @@ export class CodeCatalystCreateWebview extends VueWebview {
         return branches.flatten().promise()
     }
 
+    public isThirdPartyRepo(codeCatalystRepo: GetSourceRepositoryCloneUrlsRequest): Promise<boolean> {
+        return isThirdPartyRepo(this.client, codeCatalystRepo)
+    }
+
     public getAllInstanceDescriptions() {
         return getAllInstanceDescriptions()
     }

src/codecatalyst/vue/create/source.vue

@@ -51,12 +51,13 @@
             <!-- New Branch -->
             <span class="flex-sizing">
                 <label class="options-label soft mb-8" style="display: block" for="branch-input"
-                    >Optional - Create a Branch from an Existing Branch</label
+                    >Create Branch - Optional for CodeCatalyst Repos</label
                 >
                 <input
                     id="branch-input"
                     type="text"
-                    placeholder="branch-name"
+                    :placeholder="newBranchNamePlaceholder"
+                    :disabled="!newBranchNameAllowed"
                     v-model="model.newBranch"
                     @input="update"
                 />
@@ -116,6 +117,8 @@ export default defineComponent({
             branches: {} as Record<string, CodeCatalystBranch[] | undefined>,
             loadingProjects: false,
             loadingBranches: {} as Record<string, boolean | undefined>,
+            newBranchNameAllowed: false,
+            newBranchNamePlaceholder: 'Select branch first...',
         }
     },
     async created() {
@@ -133,6 +136,40 @@ export default defineComponent({
                 this.useFirstBranch()
             }
         },
+        async 'model.selectedBranch'(branch?: CodeCatalystBranch) {
+            if (this.model.type !== 'linked' || branch === undefined) {
+                this.newBranchNameAllowed = false
+                this.newBranchNamePlaceholder = ''
+                return
+            }
+
+            // Disable user input for new branch name while calculating
+            this.newBranchNameAllowed = false
+            this.newBranchNamePlaceholder = 'Loading...'
+
+            // Clear the existing new branch value so user does not see it
+            const previousNewBranch = this.model.newBranch
+            this.$emit('update:modelValue', { ...this.model, newBranch: undefined })
+
+            // Only want to allow users to set a branch name if first party repo
+            const isThirdPartyRepo = await client.isThirdPartyRepo({
+                spaceName: branch.org.name,
+                projectName: branch.project.name,
+                sourceRepositoryName: branch.repo.name,
+            })
+            if (isThirdPartyRepo) {
+                this.newBranchNamePlaceholder = 'Not Applicable for Linked Repo'
+                this.newBranchNameAllowed = false
+                // Clear the new branch in case one was already selected
+                this.$emit('update:modelValue', { ...this.model, newBranch: undefined })
+            } else {
+                // First Party
+                this.newBranchNamePlaceholder = 'branch-name'
+                this.newBranchNameAllowed = true
+                // Since this can have a new branch, set this back to what it previously was
+                this.$emit('update:modelValue', { ...this.model, newBranch: previousNewBranch })
+            }
+        },
     },
     computed: {
         model() {

src/shared/clients/codecatalystClient.ts

@@ -745,7 +745,7 @@ export async function excludeThirdPartyRepos(
  *
  * 1P is CodeCatalyst, 3P is something like Github.
  */
-async function isThirdPartyRepo(
+export async function isThirdPartyRepo(
     client: CodeCatalystClient,
     codeCatalystRepo: GetSourceRepositoryCloneUrlsRequest
 ): Promise<boolean> {