feedback

Author: leigaol

packages/core/src/shared/lsp/utils/platform.ts

@@ -26,23 +26,25 @@ function getEncryptionInit(key: Buffer): string {
     return JSON.stringify(request) + '\n'
 }
 
+// use dynamic linking to let node binary
+// pick up GLIBC >= 2.28
 const al2Config = {
     path: '/opt/vsc-sysroot/lib64/ld-linux-x86-64.so.2',
     args: ['--library-path', '/opt/vsc-sysroot/lib64'],
 }
-
+function createNodeProcess(nodePath: string, args: string[]) {
+    return new ChildProcess(
+        isAmazonInternalOs() ? al2Config.path : nodePath,
+        isAmazonInternalOs() ? [...al2Config.args, nodePath, ...args] : [...args],
+        { logging: 'no' }
+    )
+}
 /**
  * Checks that we can actually run the `node` executable and execute code with it.
  */
 export async function validateNodeExe(nodePath: string, lsp: string, args: string[], logger: Logger) {
     // Check that we can start `node` by itself.
-    const proc = new ChildProcess(
-        isAmazonInternalOs() ? al2Config.path : nodePath,
-        isAmazonInternalOs()
-            ? [...al2Config.args, nodePath, '-e', 'console.log("ok " + process.version)']
-            : ['-e', 'console.log("ok " + process.version)'],
-        { logging: 'no' }
-    )
+    const proc = createNodeProcess(nodePath, ['-e', 'console.log("ok")'])
     const r = await proc.run()
     const ok = r.exitCode === 0 && r.stdout.includes('ok')
     if (!ok) {
@@ -52,11 +54,7 @@ export async function validateNodeExe(nodePath: string, lsp: string, args: strin
     }
 
     // Check that we can start `node …/lsp.js --stdio …`.
-    const lspProc = new ChildProcess(
-        isAmazonInternalOs() ? al2Config.path : nodePath,
-        isAmazonInternalOs() ? [...al2Config.args, nodePath, lsp, ...args] : [lsp, ...args],
-        { logging: 'no' }
-    )
+    const lspProc = createNodeProcess(nodePath, [lsp, ...args])
 
     try {
         // Start asynchronously (it never stops; we need to stop it below).
@@ -105,11 +103,7 @@ export function createServerOptions({
         if (isDebugInstance()) {
             args.unshift('--inspect=6080')
         }
-        const lspProcess = new ChildProcess(
-            isAmazonInternalOs() ? al2Config.path : executable,
-            isAmazonInternalOs() ? [...al2Config.args, executable, ...args] : args,
-            { logging: 'no' }
-        )
+        const lspProcess = createNodeProcess(executable, args)
         // this is a long running process, awaiting it will never resolve
         void lspProcess.run()