|
3 | 3 | * SPDX-License-Identifier: Apache-2.0 |
4 | 4 | */ |
5 | 5 |
|
6 | | -// import assert from 'assert' |
7 | | -// import * as semver from 'semver' |
8 | | -// import * as env from '../shared/vscode/env' |
| 6 | +import assert from 'assert' |
| 7 | +import * as semver from 'semver' |
| 8 | +import * as env from '../shared/vscode/env' |
9 | 9 |
|
10 | 10 | // Checks project config and dependencies, to remind us to remove old things |
11 | 11 | // when possible. |
12 | 12 | describe('tech debt', function () { |
13 | 13 | it('vscode minimum version', async function () { |
14 | | - // const minVscode = env.getMinVscodeVersion() |
15 | | - // assert.ok( |
16 | | - // semver.lt(minVscode, '1.75.0'), |
17 | | - // 'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead (after Cloud9 VFS fixes bug)' |
18 | | - // ) |
19 | | - // assert.ok( |
20 | | - // semver.lt(minVscode, '1.75.0'), |
21 | | - // 'remove AsyncLocalStorage polyfill used in `spans.ts` if Cloud9 is on node 14+' |
22 | | - // ) |
| 14 | + const minVscode = env.getMinVscodeVersion() |
| 15 | + |
| 16 | + assert.ok( |
| 17 | + semver.lt(minVscode, '1.75.0'), |
| 18 | + 'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead (after Cloud9 VFS fixes bug)' |
| 19 | + ) |
| 20 | + |
| 21 | + assert.ok( |
| 22 | + semver.lt(minVscode, '1.75.0'), |
| 23 | + 'remove AsyncLocalStorage polyfill used in `spans.ts` if Cloud9 is on node 14+' |
| 24 | + ) |
23 | 25 | }) |
24 | 26 |
|
25 | 27 | it('nodejs minimum version', async function () { |
26 | | - // const minNodejs = env.getMinNodejsVersion() |
| 28 | + const minNodejs = env.getMinNodejsVersion() |
| 29 | + |
27 | 30 | // XXX: available since node 16, but not sure how much work this will be, yet. |
28 | | - // assert.ok( |
29 | | - // semver.lt(minNodejs, '18.0.0'), |
30 | | - // 'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)' |
31 | | - // ) |
| 31 | + assert.ok( |
| 32 | + semver.lt(minNodejs, '18.0.0'), |
| 33 | + 'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)' |
| 34 | + ) |
32 | 35 | }) |
33 | 36 | }) |
0 commit comments